<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 14/12/2013 07:02, Markus Mohrhard
wrote:<br>
</div>
<blockquote
cite="mid:CAEDdEt7Ow9vcA6O6GPqmmreOxqcXVUhKGS1ruMcz1f8zU5N2jg@mail.gmail.com"
type="cite">
<div dir="ltr">Hey,<br>
<div class="gmail_extra"><br>
<br>
<div class="gmail_quote">2013/12/13 julien2412 <span
dir="ltr"><<a moz-do-not-send="true"
href="mailto:serval2412@yahoo.fr" target="_blank">serval2412@yahoo.fr</a>></span><br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
Hello,<br>
<br>
Cppcheck reported this:<br>
[oox/source/export/chartexport.cxx:1822] -><br>
[oox/source/export/chartexport.cxx:1822]: (style) Same
expression on both<br>
sides of '=='.<br>
<br>
Indeed we have:<br>
1822 if (aValues[i] == aValues[i])<br>
1823 pFS->write( aValues[i] );<br>
see<br>
<a moz-do-not-send="true"
href="http://opengrok.libreoffice.org/xref/core/oox/source/export/chartexport.cxx#1790"
target="_blank">http://opengrok.libreoffice.org/xref/core/oox/source/export/chartexport.cxx#1790</a><br>
(at this moment)<br>
<br>
I thought first about == overloading but didn't find it
(or missed it)<br>
<br>
Any idea?<br>
<br>
<br>
</blockquote>
<div> </div>
<div>Actually that code is correct. This check prevents
writing out NaN because NaN is not equal to itself.
However I'll change it later to make cppcheck happy.<br>
</div>
</div>
</div>
</div>
</blockquote>
Hello Markus,<br>
<br>
Thank you for
<a class="moz-txt-link-freetext" href="http://cgit.freedesktop.org/libreoffice/core/commit/?id=af7b4eca3db99a63202df285a7df7402e523ff54">http://cgit.freedesktop.org/libreoffice/core/commit/?id=af7b4eca3db99a63202df285a7df7402e523ff54</a>
:-)<br>
<br>
Julien<br>
</body>
</html>