<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW --- - move java based api tests to c++"
href="https://bugs.freedesktop.org/show_bug.cgi?id=45904#c14">Comment # 14</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW --- - move java based api tests to c++"
href="https://bugs.freedesktop.org/show_bug.cgi?id=45904">bug 45904</a>
from <span class="vcard"><a class="email" href="mailto:rivera151@gmail.com" title="Ricardo <rivera151@gmail.com>"> <span class="fn">Ricardo</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=45904#c9">comment #9</a>)
<span class="quote">> So I'll try to add a few more details but I'm currently on vacation. So
> please excuse if it is not in as much detail as it should be.
>
> Currently our api test code is at qadevooo/tests/java/ and there in there in
> the folders IFC and mod.
>
> The implementation is divided between these two folders to represent our two
> parts of the api implementations. The sender IFC part is for the interface
> definition that is represented in our api through the IDL files in offapi
> and can be found at api.LibreOffice.org. the mod part is for the actual
> implementation that implements several interfaces.
>
> We have a similar structure for the c++ tests. The test code for the
> interfaces can be found in test/ and the code for the implementations for
> calc in sc/qa/extras.
>
> Each file in sc/qa/extras represents one implementation file and is one
> cppunit test that is registered by a make file in sc/ and in
> sc/module_sc.mk. the new tests just make it explicit which interfaces are
> tested while it is implicitly done in the old java tests by querying for all
> interfaces the object provides.
>
> So we now need a two step process to convert old tests. First convert the
> interface test code and implement it in test/ and secondly convert or better
> write a clean new implementation for the api implementation.
>
> The c++ implementation should however try to make the tests better by using
> the assertion macros that are provided by cppunit, make explicit what was
> implicit in the old implementation and improve the diagnostic messages. A
> good start would be to look at some of Tue code that I already converted to
> c++.
>
> If you have more questions please ask and I'll try to answer as soon as
> possible. I'll return next week from my vacation so I can answer questions
> after that also by irc.</span >
This is what needs to be done, if I interpreted correctly:
1. Pick a folder from qaDevOOo/tests/java/ifc (Pick an interface)
2. Implement the interface picked into test/source (Organized into folders as
in original implementation
3. Pick a folder from qaDevOOo/tests/java/mod (Test cases, organized in
folders, let's call it mod_name here)
4. Implement the tests into the folder mod_name/qa/extras (mod_name folder at
project root)
Is this correct?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>