<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:yusupmuk@fel.cvut.cz" title="Mukhiddin Yusupov <yusupmuk@fel.cvut.cz>"> <span class="fn">Mukhiddin Yusupov</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEEDINFO "
title="NEEDINFO --- - Clean up OSL_ASSERT, DBG_ASSERT, etc."
href="https://bugs.freedesktop.org/show_bug.cgi?id=43157">bug 43157</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>NEW
</td>
<td>NEEDINFO
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEEDINFO "
title="NEEDINFO --- - Clean up OSL_ASSERT, DBG_ASSERT, etc."
href="https://bugs.freedesktop.org/show_bug.cgi?id=43157#c25">Comment # 25</a>
on <a class="bz_bug_link
bz_status_NEEDINFO "
title="NEEDINFO --- - Clean up OSL_ASSERT, DBG_ASSERT, etc."
href="https://bugs.freedesktop.org/show_bug.cgi?id=43157">bug 43157</a>
from <span class="vcard"><a class="email" href="mailto:yusupmuk@fel.cvut.cz" title="Mukhiddin Yusupov <yusupmuk@fel.cvut.cz>"> <span class="fn">Mukhiddin Yusupov</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=43157#c0">comment #0</a>)
<span class="quote">> The assertion/logging functionality from osl/diagnose.h (OSL_TRACE,
> OSL_ASSERT, OSL_ENSURE, OSL_FAIL) and tools/debug.hxx (DBG_ASSERTWARNING,
> DBG_ASSERT, DBG_BF_ASSERT, DBG_WARNING, DBG_WARNING1--5, DBG_WARNINGFILE,
> DBG_ERRORFILE) is obsolete and needs to be cleaned up:
>
> * To assert invariants of the code (that can only be violated if there are
> programming errors) use standard C/C++ assert.
>
> * To log warnings about unusual events (that the code nevertheless needs to
> handle in some way, like malformed input or I/O failures), use the
> SAL_WARN... macros from sal/log.h.
>
> * To log other information useful for debugging, use the SAL_INFO... macros.
>
> See
> <<a href="https://wiki.documentfoundation.org/Development#Assertions_and_Logging">https://wiki.documentfoundation.org/Development#Assertions_and_Logging</a>>,
> the mail thread at
> <<a href="http://lists.freedesktop.org/archives/libreoffice/2011-November/020864">http://lists.freedesktop.org/archives/libreoffice/2011-November/020864</a>.
> html>, and the documentation in the sal/log.h header for further information.</span >
In spite of the fact that many people uploaded commits I found that in some
files these obsolete assertions/logging. I am going to change as many of these
files as I can.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>