<html> <head> <base href="https://bugs.freedesktop.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - replace #defined constants with ‘enum class’" href="https://bugs.freedesktop.org/show_bug.cgi?id=84938#c5">Comment # 5</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - replace #defined constants with ‘enum class’" href="https://bugs.freedesktop.org/show_bug.cgi?id=84938">bug 84938</a> from <a class="email" href="mailto:lo_bugs@iseries-guru.com" title="Terrence Enger <lo_bugs@iseries-guru.com>"> Terrence Enger</a> <pre>I have started hacking on the names starting DSID_ defined in dbaccess/source/ui/inc/dsitems.hxx. Some observations and questions arising: (*) I have the name DatasourceItemId for the class. Is this good? (*) The member name looks like a #defined name: uppercase with underscores between "words". Does anybody care for more details? (*) I have changed to types of data members in some other classes. I do not see why these variables are necessary, but I have not dug into the question. (*) So far, I have arbitrarily limited my changes to dbaccess; when an item goes outside the module--SfxItemSet comes to mind--I have cast the item to int. Is this a reasonable way to do it? Failing that, is the result worth anything? (*) The TODO comments in DriverSettings.cxx were invaluable in relieving the feeling of disorientation which comes from thinking, over and over, "Damn. I thought I already changed this." My plan now is to play with Base a bit. Terry.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are on the CC list for the bug.</li> </ul> </body> </html>