<html>
<head>
<base href="https://bugs.freedesktop.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - replace #defined constants with ‘enum class’"
href="https://bugs.freedesktop.org/show_bug.cgi?id=84938#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - replace #defined constants with ‘enum class’"
href="https://bugs.freedesktop.org/show_bug.cgi?id=84938">bug 84938</a>
from <span class="vcard"><a class="email" href="mailto:noelgrandin@gmail.com" title="Noel Grandin <noelgrandin@gmail.com>"> <span class="fn">Noel Grandin</span></a>
</span></b>
<pre>Glad to here you are working on this!
(In reply to Terrence Enger from <a href="show_bug.cgi?id=84938#c5">comment #5</a>)
<span class="quote">> (*) I have the name DatasourceItemId for the class. Is this good?
> </span >
Sounds finee.
<span class="quote">> (*) The member name looks like a #defined name: uppercase with
> underscores between "words". Does anybody care for more details?
> </span >
Sounds fine.
<span class="quote">> (*) I have changed to types of data members in some other classes. I
> do not see why these variables are necessary, but I have not dug
> into the question.
> </span >
That's pretty normal.
<span class="quote">> (*) So far, I have arbitrarily limited my changes to dbaccess; when
> an item goes outside the module--SfxItemSet comes to mind--I have
> cast the item to int. Is this a reasonable way to do it? Failing
> that, is the result worth anything?
> </span >
That's a normal approach, except for cases where something else might be
#including headers from dbaccess, in which case I'd except the code to
be modified to use the new 'enum class' type.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>