<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div>That does look an error. </div><div><br></div><div>I've rebased and started a build - can't see any issues though!</div><div><br></div><div>Chris<br><br>Sent from my iPhone</div><div><br>On 21 Dec 2014, at 7:41 am, Maarten Hoes <<a href="mailto:hoes.maarten@gmail.com">hoes.maarten@gmail.com</a>> wrote:<br><br></div><blockquote type="cite"><div><div dir="ltr"><div><div>Hi,<br><br><br></div>I made the minimum amount of change I needed, and submitted a patch to gerrit for review.<br><br><a href="https://gerrit.libreoffice.org/13568">https://gerrit.libreoffice.org/13568</a><br><br></div>- Maarten<br><div><br><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Dec 20, 2014 at 12:23 PM, Maarten Hoes <span dir="ltr"><<a href="mailto:hoes.maarten@gmail.com" target="_blank">hoes.maarten@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>Hi,<br><br><br>For lcov code coverage purposes, I have to build libreoffice with the following FLAGS set and exported :<br><br>LDFLAGS='-fprofile-arcs' CFLAGS='-fprofile-arcs -ftest-coverage' CXXFLAGS='-fprofile-arcs -ftest-coverage' CPPFLAGS='-fprofile-arcs -ftest-coverage'<br>export LDFLAGS CFLAGS CXXFLAGS CPPFLAGS<br><br>And then proceed with <br><br>./autogen.sh --enable-python=internal --disable-online-update --without-system-libs --without-system-headers<br>make build-nocheck<br><br>I run into a build error of the internal openldap version, with undefined references to '__gcov_'. This shouldnt happen when setting FLAGS+='-fprofile-arcs -ftest-coverage' ... But it looks like '-lgcov' isnt passed to the linker properly (which should happen by setting LDFLAGS='-fprofile-arcs'). It appears that the FLAGS arent being passed down correctly in here :<br><br>external/openldap/ExternalProject_openldap.mk<br><br>Where at multiple points it appears that all current CFLAGS/CPPFLAGS/LDFLAGS are overwritten with entries like this:<br><br>LDFLAGS = foo<br>CPPFLAGS= bar<br><br>instead of something like this<br><br>LDFLAGS="$(LDFLAGS) foo"<br></div><div>CPPFLAGS="$(CPPFLAGS) bar"<br><br>It seems easy enough to modify, but I cant figure out if this was done on purpose for some reason, or if it can be modified without causing issues ? Perhaps only the (last) line with LDFLAGS can/needs to be changed, and the other FLAGS need to be left as they are ? For me, internal openldap builds without issues when making the modifications (see attached diff).<br><br><br>All thoughts and comments are more than appreciated, <br><br><br><br>- Maarten<br><br></div></div>
</blockquote></div><br></div></div>
</div></blockquote><blockquote type="cite"><div><span>_______________________________________________</span><br><span>LibreOffice mailing list</span><br><span><a href="mailto:LibreOffice@lists.freedesktop.org">LibreOffice@lists.freedesktop.org</a></span><br><span><a href="http://lists.freedesktop.org/mailman/listinfo/libreoffice">http://lists.freedesktop.org/mailman/listinfo/libreoffice</a></span><br></div></blockquote></body></html>