<div dir="ltr">UNSUBSCRIBE</div><div class="gmail_extra"> <div class="gmail_quote">On Sun, Dec 28, 2014 at 11:08 AM, julien2412 <<a href="mailto:serval2412@yahoo.fr" target="_blank">serval2412@yahoo.fr</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hello, I noticed this part: 889 void ScDBCollection::DeleteOnTab( SCTAB nTab ) 890 { ... 908 remove_if(maAnonDBs.begin(), maAnonDBs.end(), func); 909 } "remove_if" is useless since there's no erase. I thought about adding an "erase" by taking example of this <a href="http://en.wikipedia.org/wiki/Erase-remove_idiom" target="_blank">http://en.wikipedia.org/wiki/Erase-remove_idiom</a> but AnonDBs doesn't have an ad hoc erase method (like NamedDBs, but this one has a "simple" erase method), see <a href="http://opengrok.libreoffice.org/xref/core/sc/inc/dbdata.hxx#152" target="_blank">http://opengrok.libreoffice.org/xref/core/sc/inc/dbdata.hxx#152</a> Should we remove this line? Should we add an ad hoc "erase" method to implement erase-remove idiom in NamedDBs + AnonDBs? Any thoughts? Julien -- View this message in context: <a href="http://nabble.documentfoundation.org/remove-if-for-nothing-in-dbdata-cxx-sc-module-tp4134249.html" target="_blank">http://nabble.documentfoundation.org/remove-if-for-nothing-in-dbdata-cxx-sc-module-tp4134249.html</a> Sent from the Dev mailing list archive at Nabble.com. _______________________________________________ LibreOffice mailing list <a href="mailto:LibreOffice@lists.freedesktop.org">LibreOffice@lists.freedesktop.org</a> <a href="http://lists.freedesktop.org/mailman/listinfo/libreoffice" target="_blank">http://lists.freedesktop.org/mailman/listinfo/libreoffice</a> </blockquote></div> </div>