<html><body><div style="color:#000; background-color:#fff; font-family:HelveticaNeue-Light, Helvetica Neue Light, Helvetica Neue, Helvetica, Arial, Lucida Grande, sans-serif;font-size:16px"><div dir="ltr" id="yui_3_16_0_1_1420649318707_221576"><span id="yui_3_16_0_1_1420649318707_221874">It seems that --enable-crashdump is causing ide-integration to break. This looks to me as something potentially related to this thread.</span></div><div dir="ltr" id="yui_3_16_0_1_1420649318707_221576"><span><br></span></div><div dir="ltr" id="yui_3_16_0_1_1420649318707_221576"><span id="yui_3_16_0_1_1420649318707_222715">Submitted fdo#</span>88279 with details.</div> <div class="qtdSeparateBR"><br><br></div><div class="yahoo_quoted" style="display: block;"> <div style="font-family: HelveticaNeue-Light, Helvetica Neue Light, Helvetica Neue, Helvetica, Arial, Lucida Grande, sans-serif; font-size: 16px;"> <div style="font-family: HelveticaNeue, Helvetica Neue, Helvetica, Arial, Lucida Grande, sans-serif; font-size: 16px;"> <div dir="ltr"> <font size="2" face="Arial"> On Friday, January 9, 2015 12:10 PM, Michael Stahl <mstahl@redhat.com> wrote:<br> </font> </div> <blockquote style="border-left: 2px solid rgb(16, 16, 255); margin-left: 5px; margin-top: 5px; padding-left: 5px;"> <br><br> <div class="y_msg_container">hi Ashod,<br clear="none"><br clear="none">On 09.01.2015 16:56, Ashod Nakashian wrote:<br clear="none">> I suspected this was a recent issue as it wouldn't make sense to have<br clear="none">> this broken for a long time. Still, I went ahead and spent yesterday<br clear="none">> adding the /FS flag.<br clear="none"><br clear="none">thanks for investigating the problem, unfortunately i didn't look at the<br clear="none">gerrit patches today so did not see your patch.<br clear="none"><br clear="none">> I noticed that in some cases the build would still break with this error<br clear="none">> (See Build 228[*] against my commit to fix this). Although I couldn't<br clear="none">> reproduce it on my local machine (also building with 12 threads like<br clear="none">> Jenkins,) when before the fix I couldn't complete a single successful<br clear="none">> parallel build.<br clear="none">> <br clear="none">> The only drawback of /FS is that it sends PDF file writes through the<br clear="none">> pdb server, which is slower than direct disk write. However, in my<br clear="none">> patch, the flag is only set for parallelized builds where it's<br clear="none">> beneficial. You can check out my patch here[$].<br clear="none"><br clear="none">it is true that it may be slower in a non-parallel build, but nobody<br clear="none">does a non-parallel build and expects that to be fast, so it's not an<br clear="none">issue (and much simpler) to just unconditionally use -FS.<br clear="none"><br clear="none">> Question 1: Do we still need to add the /FS flag for parallelized builds?<br clear="none"><br clear="none">it is already added in solenv/gbuild/platform/com_MSC_defs.mk<br clear="none">and in solenv/gcc-wrappers/wrapper.cxx<br clear="none"><br clear="none">the problem was that the removal of "crashrep" left an environment<br clear="none">variable wrongly defined, which caused the -Zi without -FS breaker.<br clear="none"><br clear="none">> Question 2: Will an admin rebuild the failed Jenkins jobs, or what's the<br clear="none">> procedure in this case?<br clear="none"><br clear="none">for your -FS patch it's not necessary since the patch is not needed (see<br clear="none">above); if you have other gerrit patches where the build broke the<br clear="none">re-build is not automatic, but if you look at your patch in gerrit there<br clear="none">is a "Rebase" button which will re-base it to the current master (with<br clear="none">the fix), and starting a new build after re-base it should work.<br clear="none"><br clear="none">> P.S. I'm rather new to Libreoffice and just submitted two patches. Would<br clear="none">> like some constructive feedback to make my contributions both more<br clear="none">> efficient and valuable.<br clear="none"><br clear="none">welcome and thanks for your contributions!<div class="yqt9055218527" id="yqtfd09458"><br clear="none"><br clear="none"><br clear="none">_______________________________________________<br clear="none">LibreOffice mailing list<br clear="none"><a shape="rect" ymailto="mailto:LibreOffice@lists.freedesktop.org" href="mailto:LibreOffice@lists.freedesktop.org">LibreOffice@lists.freedesktop.org</a><br clear="none"><a shape="rect" href="http://lists.freedesktop.org/mailman/listinfo/libreoffice" target="_blank">http://lists.freedesktop.org/mailman/listinfo/libreoffice</a><br clear="none"></div><br><br></div> </blockquote> </div> </div> </div> </div></body></html>