<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Hi all, <div class=""><br class=""></div><div class="">I’ve been looking at some things in the LO codebase, and I noticed that we aren’t always displaying sample text in the font combobox (used in sidebar, writer toolbar and calc toolbar). </div><div class=""><br class=""></div><div class="">I have actually winkled down the issue to an issue in the code in FontNameBox::UserDraw</div><div class=""><br class=""></div><div class="">The code assumes that it needs to help fonts that can’t render their own Latin-based font family names, then it needs to provide sample text - but it does a very specific lookup for the particular font to get the sample text. I guess that’s OK, but frankly I don’t want to update the code every time a font like this comes out - I don’t think this is scalable, and besides you have to update LO to get this minor feature (and I think it unlikely developers will want to anyway). </div><div class=""><br class=""></div><div class="">Anyhow, I’ve put a brief code commit to gerrit, the reason I haven’t pushed it is because it appears that some Latin fonts are show the sample text as “AB”. Other than this, the patch is working like a charm. </div><div class=""><br class=""></div><div class="">Can anyone see why the text is coming up for these latin based fonts as “AB”? The goal for these fonts is that we don’t *need* to show any sample text. </div><div class=""><br class=""></div><div class="">Bug report filed here:</div><div class=""><br class=""></div><div class=""><a href="https://bugs.freedesktop.org/show_bug.cgi?id=88484" class="">https://bugs.freedesktop.org/show_bug.cgi?id=88484</a></div><div class=""><br class=""></div><div class="">Gerrit review is here:</div><div class=""><br class=""></div><div class=""><a href="https://gerrit.libreoffice.org/#/c/13952/" class="">https://gerrit.libreoffice.org/#/c/13952/</a></div><div class=""><br class=""></div><div class="">Any pointers or help would be gratefully accepted :-) I suppose it’s very minor in the grand scheme of things, but I quite like the feature and I think making our software friendly for other languages and cultures is worthwhile!</div><div class=""><br class=""></div><div class="">Chris</div></body></html>