<html> <head> <base href="https://bugs.documentfoundation.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_ASSIGNED " title="ASSIGNED - reduce some copy&paste code in ucalc" href="https://bugs.documentfoundation.org/show_bug.cgi?id=90290#c7">Comment # 7</a> on <a class="bz_bug_link bz_status_ASSIGNED " title="ASSIGNED - reduce some copy&paste code in ucalc" href="https://bugs.documentfoundation.org/show_bug.cgi?id=90290">bug 90290</a> from <a class="email" href="mailto:libreoffice@kohei.us" title="Kohei Yoshida <libreoffice@kohei.us>"> Kohei Yoshida</a> <pre>BTW, just to mention this for the record, I did this type if (!checkFormula(*m_pDoc, aPos, "SUM(A3:A7)")) CPPUNIT_FAIL("Wrong formula!"); of checks so that when it fails, you can get the line number of where the check actually fails. One disadvantage of writing a common function for this is that when the check fails, the line number now points where inside that shared function, not where it was called, and then you'd have to do some hunting to see which check actually failed in what test case. I'm not saying "don't do it", but I'm simply saying there is a thought behind it, and there is a disadvantage to "cleaning it up".</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are on the CC list for the bug.</li> </ul> </body> </html>