<html>
<head>
<base href="https://bugs.documentfoundation.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:dtardon@redhat.com" title="David Tardon <dtardon@redhat.com>"> <span class="fn">David Tardon</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - reduce some copy&paste code in ucalc"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=90290">bug 90290</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>dtardon@redhat.com
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - reduce some copy&paste code in ucalc"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=90290#c13">Comment # 13</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - reduce some copy&paste code in ucalc"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=90290">bug 90290</a>
from <span class="vcard"><a class="email" href="mailto:dtardon@redhat.com" title="David Tardon <dtardon@redhat.com>"> <span class="fn">David Tardon</span></a>
</span></b>
<pre>(In reply to Markus Mohrhard from <a href="show_bug.cgi?id=90290#c0">comment #0</a>)
<span class="quote">> ucalc is one of the mail calc tests and is split between many files in
> sc/qa/unit
>
> This task is about improving the existing pattern around checkFormula in
> sc/qa/unit/ucalc_formula.cxx
>
> A typical piece of code looks like this:
>
> if (!checkFormula(*m_pDoc, aPos, "SUM(A3:A7)"))
> CPPUNIT_FAIL("Wrong formula!");
>
> This should be changed to something like:
>
> checkFormula(*m_pDoc, aPos, "SUM(A3:A7)", "Wrong formula!");</span >
What is wrong with
CPPUNIT_ASSERT_MESSAGE("Wrong formula!", checkFormula(*m_pDoc, aPos,
"SUM(A3:A7)"))
? That would address Kohei's concerns without any necessary changes to cppunit.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>