<html> <head> <base href="https://bugs.documentfoundation.org/" /> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - reduce some copy&paste code in ucalc" href="https://bugs.documentfoundation.org/show_bug.cgi?id=90290#c14">Comment # 14</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - reduce some copy&paste code in ucalc" href="https://bugs.documentfoundation.org/show_bug.cgi?id=90290">bug 90290</a> from <a class="email" href="mailto:markus.mohrhard@googlemail.com" title="Markus Mohrhard <markus.mohrhard@googlemail.com>"> Markus Mohrhard</a> <pre>(In reply to David Tardon from <a href="show_bug.cgi?id=90290#c13">comment #13</a>) > (In reply to Markus Mohrhard from <a href="show_bug.cgi?id=90290#c0">comment #0</a>) > > ucalc is one of the mail calc tests and is split between many files in > > sc/qa/unit > > > > This task is about improving the existing pattern around checkFormula in > > sc/qa/unit/ucalc_formula.cxx > > > > A typical piece of code looks like this: > > > > if (!checkFormula(*m_pDoc, aPos, "SUM(A3:A7)")) > > CPPUNIT_FAIL("Wrong formula!"); > > > > This should be changed to something like: > > > > checkFormula(*m_pDoc, aPos, "SUM(A3:A7)", "Wrong formula!"); > > What is wrong with > > CPPUNIT_ASSERT_MESSAGE("Wrong formula!", checkFormula(*m_pDoc, aPos, > "SUM(A3:A7)")) > > ? That would address Kohei's concerns without any necessary changes to > cppunit. I already talked to Kohei and he seems to be fine with changing it. The reason that I wanted to move to CPPUNIT_ASSERT_EQUAL is that it will print both strings in case of a failure which is extremely helpful for debugging. I think if necessary we can implement Tor's suggestion in LibreOffice. There is no need to do it in CPPUNIT as there should be already support for an own asserter message.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are on the CC list for the bug.</li> </ul> </body> </html>