<html>
<head>
<base href="https://bugs.documentfoundation.org/" />
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_UNCONFIRMED "
title="UNCONFIRMED - Fix the HiDPI wave underline character property"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=90793">90793</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>Fix the HiDPI wave underline character property
</td>
</tr>
<tr>
<th>Product</th>
<td>LibreOffice
</td>
</tr>
<tr>
<th>Version</th>
<td>4.2.3.3 release
</td>
</tr>
<tr>
<th>Hardware</th>
<td>Other
</td>
</tr>
<tr>
<th>OS</th>
<td>Linux (All)
</td>
</tr>
<tr>
<th>Status</th>
<td>UNCONFIRMED
</td>
</tr>
<tr>
<th>Severity</th>
<td>normal
</td>
</tr>
<tr>
<th>Priority</th>
<td>medium
</td>
</tr>
<tr>
<th>Component</th>
<td>UI
</td>
</tr>
<tr>
<th>Assignee</th>
<td>libreoffice-bugs@lists.freedesktop.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>keithcu@gmail.com
</td>
</tr>
<tr>
<th>CC</th>
<td>libreoffice@lists.freedesktop.org
</td>
</tr></table>
<p>
<div>
<pre>LibreOffice since 4.2.3 draws the spelling and grammar error waves lines nicely
on HiDPI screens. This was done via changes to the OutputDevice::DrawWaveLine
routine:
<a href="http://opengrok.libreoffice.org/xref/core/vcl/source/outdev/textline.cxx#984">http://opengrok.libreoffice.org/xref/core/vcl/source/outdev/textline.cxx#984</a>
This fixes by far the most common use of this feature, but still we could do a
better job for the underline character properties (wave, bold-wave,
double-wave) which are hard-coded to draw 1 pixel and don't look very good. The
relevant routine for this is OutputDevice::ImplDrawWaveLine
<a href="http://opengrok.libreoffice.org/xref/core/vcl/source/outdev/textline.cxx#88">http://opengrok.libreoffice.org/xref/core/vcl/source/outdev/textline.cxx#88</a>
I believe this is an easy hack. The first question is what widths to use. The
spelling / grammar underlines are supposed to be unobtrusive, but the wave
underline character property perhaps not. I would consider changing the code to
use the underline / bold / double underline widths, or perhaps tweaks of them.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>