<div dir="ltr"> <div class="gmail_extra"> <div class="gmail_quote">On Sat, Jul 25, 2015 at 9:17 AM, Michael Meeks <<a href="mailto:michael.meeks@collabora.com" target="_blank">michael.meeks@collabora.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Markus, On Fri, 2015-07-24 at 18:22 +0200, Markus Mohrhard wrote: > so it is now the second time that despite me requesting a unit test in > a gerrit review request a patch has been pushed. Sounds like bad style. Then again - how many man-hours do we expect would be required for the tests ? [ if it is easy to test then ... worse style I guess ]. </blockquote><div> </div><div>Writing a XShape test only requires to create a test document that shows the changed code. Hopefully everyone fixing a bug has created such a document as part of the manual testing after fixing the bug. I made it clear on this list several times that I can and will help integrate the test but can't generate the files myself. </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> > I only care marginally if you do it in code that I don't maintain but > I will revert it every single time when it is in code that I maintain. I wonder what the wider context is; I imagine people are fixing crazily for -5-0-0 - and that in some cases creating a unit test consumes significant time that will stop the next fix being got at - which will ultimately result in a noticeably poorer quality 5.0.0 release. ie. we're in a short-term bug-fix crunch and this is a zero sum game to some extent. Then again, it sounds unhelpful longer term; I wonder if we could have the fixes on the -5-0-0 branch but not on master or on -5-0 (without a unit test) - which would of course be pretty 'orrible as an approach: but hopefully queue up the unit testing work to make sure that it gets done later & yet get the fix in now. Or perhaps that's a mad plan =) ATB, Michael. -- <a href="mailto:michael.meeks@collabora.com">michael.meeks@collabora.com</a> <><, Pseudo Engineer, itinerant idiot </blockquote></div> </div></div>