<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Sep 1, 2015 at 11:50 AM, Shreyansh Gandhi <span dir="ltr"><<a href="mailto:gandhishrey@gmail.com" target="_blank">gandhishrey@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Hey, I don't understand the reason why the build failed. Can you please take a look?<div><a href="http://ci.libreoffice.org/job/lo_gerrit_master/5856/console" target="_blank">http://ci.libreoffice.org/job/lo_gerrit_master/5856/console</a><br></div><div><br></div></div></blockquote><div><br></div><div>Looks like a Jenkins issue. Other builds have failed as well.<br><br></div><div>Rebase to rebuild again later when Jenkins shows some successful builds.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div></div></div><div class=""><div class="h5"><br><div class="gmail_quote"><div dir="ltr">On Tue, Sep 1, 2015 at 8:06 PM Michael Stahl <<a href="mailto:mstahl@redhat.com" target="_blank">mstahl@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 01.09.2015 15:34, Shreyansh Gandhi wrote:<br>
> I just came across<br>
> this: <a href="http://stackoverflow.com/questions/24221955/creating-a-unique-ptr-from-a-pointer" rel="noreferrer" target="_blank">http://stackoverflow.com/questions/24221955/creating-a-unique-ptr-from-a-pointer</a> .<br>
> Will it be safe to use this method to push_back into m_Selectors?<br>
<br>
yes, if it was pushing to a boost::ptr_container before (and we can<br>
assume that that works), then converting it to a unique_ptr only at the<br>
place when it is pushed is doing exactly the same thing.<br>
<br>
the only problem to watch out for, if you do it earlier and convert a<br>
variable declaration to std::unique_ptr then std::move into the<br>
container then the variable contains a null pointer now - but if you<br>
convert the bare pointer only inside the push_back call then this<br>
problem is avoided.<br>
<br>
<br>
_______________________________________________<br>
LibreOffice mailing list<br>
<a href="mailto:LibreOffice@lists.freedesktop.org" target="_blank">LibreOffice@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/libreoffice" rel="noreferrer" target="_blank">http://lists.freedesktop.org/mailman/listinfo/libreoffice</a><br>
</blockquote></div></div></div><span class=""><font color="#888888"><div dir="ltr">-- <br></div><div dir="ltr">Regards,<div>Shreyansh Gandhi</div></div>
</font></span><br>_______________________________________________<br>
LibreOffice mailing list<br>
<a href="mailto:LibreOffice@lists.freedesktop.org">LibreOffice@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/libreoffice" rel="noreferrer" target="_blank">http://lists.freedesktop.org/mailman/listinfo/libreoffice</a><br>
<br></blockquote></div><br></div></div>