<html><head></head><body>Just in case,<br> Do you know<br> git commit --amend to update last commit before pushing it to gerrit<br> And<br> git rebase -i HEAD~5 to rewrite your local commit history including for exemple modify the third commit, merge commits 1 3 and 4 into a single one?<br> Philippe<br> <br><br><div class="gmail_quote">Le 19 novembre 2015 04:20:03 CET, Ashod Nakashian <ashnakash@gmail.com> a écrit :<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"> <div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Wed, Nov 18, 2015 at 8:27 PM, Norbert Thiebaud <span dir="ltr"><<a href="mailto:nthiebaud@gmail.com" target="_blank">nthiebaud@gmail.com</a>></span> wrote:<br /><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Wed, Nov 18, 2015 at 2:28 PM, Ashod Nakashian <<a href="mailto:ashnakash@gmail.com">ashnakash@gmail.com</a>> wrote:<br /> > (Sorry if this has already been discussed/considered.)<br /> ><br /> > Once a patch is pushed to Gerrit a Jenkins build automatically starts. And<br /> > once subsequent patches are pushed the cycle repeats.<br /> ><br /> > Is there a reason to keep running the builds of (old) patches that will not<br /> > get cherry picked?<br /> <br /> </span>Is there a reason to keep pushing these patches then ?<br /> Just stop building patch over patch and pushing them in bulk.. and<br /> make your patch independent of each other as much as possible.<br /></blockquote><div><br /></div><div>Sorry, I didn't explain well.</div><div><br /></div><div>The patches are related. They are updates based on feedback, partial failure or improvement.</div><div><br /></div><div>They aren't bulk pushes (whatever that means). They are updates on a single changeset.</div><div><br /></div><div>Why do people send multiple patches per push? That's the right question to ask.<br /></div><div><br /></div><div>And the answer is: to improve the previous patch.</div><div><br /></div><div>Hence my question. If a patch has partially failed, or I got feedback to improve it, or (insert reason here), and I want to push an update, why should the previous patch still build when it's not necessary?</div><div><br /></div><div>Hope this makes sense.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <br /> iow: make a patch, push it to gerrit, come back to 'master' make<br /> another patch, push it to gerrit etc.<br /> and _not_<br /> make a patch, push it to gerrit<br /> git pull -r<br /> make another patch (on top of the non merged patch you just pushed to<br /> gerrit), push it to gerrit => both patch get rebuilt<br /> etc..<br /> <span class=""><br /></span></blockquote><div><br /></div><div>Obviously I'm not doing that. Obviously.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class=""> <br /> ><br /> > To me it looks completely wasteful to spend hours building a few patches<br /> > that were pushed one after the other when only the last one is relevant.<br /> <br /> </span>Then do not push new version of 'irrelevant' patches<br /> <span class=""><br /> > Not<br /> > only it is wasteful to valuable shared resources, but the user is punished<br /> <br /> </span>again, do not do that then.<br /> <span class="HOEnZb"><font color="#888888"><br /> Norbert<br /> </font></span></blockquote></div><br /></div></div> <p style="margin-top: 2.5em; margin-bottom: 1em; border-bottom: 1px solid #000"></p><pre class="k9mail"><hr /><br />LibreOffice mailing list<br />LibreOffice@lists.freedesktop.org<br /><a href="http://lists.freedesktop.org/mailman/listinfo/libreoffice">http://lists.freedesktop.org/mailman/listinfo/libreoffice</a><br /></pre></blockquote></div><br> -- <br> Envoyé de mon téléphone Android avec K-9 Mail. Excusez la brièveté.</body></html>