<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div>Job well done !!</div><div id="AppleMailSignature"><br></div><div id="AppleMailSignature">your patch is now on master. What will you work on next ?</div><div id="AppleMailSignature"><br></div><div id="AppleMailSignature">rgds</div><div id="AppleMailSignature">jan i<br><br>Sent from my iPad, please excuse any misspellings </div><div><br>On 14 Dec 2015, at 16:26, "<a href="mailto:flw.aquarius@gmail.com">flw.aquarius@gmail.com</a>" <<a href="mailto:flw.aquarius@gmail.com">flw.aquarius@gmail.com</a>> wrote:<br><br></div><blockquote type="cite"><div><meta http-equiv="content-type" content="text/html; charset=ISO-8859-1"><style>body { line-height: 1.5; }blockquote { margin-top: 0px; margin-bottom: 0px; margin-left: 0.5em; }div.foxdiv20151214221613953659 { }body { font-size: 10.5pt; font-family: ????; color: rgb(0, 0, 0); line-height: 1.5; }</style> <div><span></span>Hi, All!</div><div>I had push the commit to the gerrit.: <span style="background-color: rgba(0, 0, 0, 0); font-size: 10.5pt; line-height: 1.5;"></span><a href="https://gerrit.libreoffice.org/#/c/20701/" style="font-size: 10.5pt; line-height: 1.5; background-color: window;">https://gerrit.libreoffice.org/#/c/20701/</a><span style="color: rgb(0, 0, 0); font-size: 10.5pt; line-height: 1.5; background-color: rgba(0, 0, 0, 0);"> </span></div><div><span style="background-color: window; font-size: 10.5pt; line-height: 1.5;">But it build failed in '</span><span style="font-size: 10.5pt; line-height: 1.5; background-color: window;">CppunitTest/libtest_writerperfect_stream.so'</span><span style="font-size: 10.5pt; line-height: 1.5; background-color: window;">: </span><a href="http://ci.libreoffice.org/job/lo_gerrit_master/9226/" target="_blank" style="font-size: 10.5pt; line-height: 1.5; background-color: window;">http://ci.libreoffice.org/job/lo_gerrit_master/9226/</a></div><div>It work well in my machine. Is anyone have a good idear to fix this bug ?</div><div>Thanks!</div><div><br></div><span style="color: rgb(0, 0, 0); background-color: rgba(0, 0, 0, 0);"></span> <div><br></div><hr style="width: 210px; height: 1px;" color="#b5c4df" size="1" align="left"> <div><span><div style="MARGIN: 10px; FONT-FAMILY: verdana; FONT-SIZE: 10pt"><div><a href="mailto:flw.aquarius@gmail.com">flw.aquarius@gmail.com</a></div></div></span></div> <blockquote style="margin-top: 0px; margin-bottom: 0px; margin-left: 0.5em;"><div> </div><div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm"><div style="PADDING-RIGHT: 8px; PADDING-LEFT: 8px; FONT-SIZE: 12px;FONT-FAMILY:tahoma;COLOR:#000000; BACKGROUND: #efefef; PADDING-BOTTOM: 8px; PADDING-TOP: 8px"><div><b>From:</b> <a href="mailto:flw.aquarius@gmail.com">flw.aquarius@gmail.com</a></div><div><b>Date:</b> 2015-12-13 20:26</div><div><b>To:</b> <a href="mailto:libreoffice@lists.freedesktop.org">libreoffice</a></div><div><b>Subject:</b> fix paint table border in DOUBLE_THIN style</div></div></div><div><div class="FoxDiv20151214221613953659"> <div><span style="color: rgb(0, 0, 0); background-color: rgba(0, 0, 0, 0);">Hi, I find a bug in the master branch and fixed it. But i am in trouble when i push the patch to the gerrit. It the waring fllow:</span></div><div><span style="color: rgb(0, 0, 0); background-color: rgba(0, 0, 0, 0);"><br></span></div><div><span style="color: rgb(0, 0, 0); background-color: rgba(0, 0, 0, 0);">The authenticity of host '[<a href="http://gerrit.libreoffice.org">gerrit.libreoffice.org</a>]:29418 ([89.238.68.148]:29418)' can't be established.<br></span></div><div><span style="color: rgb(0, 0, 0); background-color: rgba(0, 0, 0, 0);"><br></span></div><div><span style="color: rgb(0, 0, 0); background-color: rgba(0, 0, 0, 0);">So, i show </span><span style="font-size: 10.5pt; line-height: 1.5; background-color: window;">the screenshot to show the bug and</span><span style="background-color: rgba(0, 0, 0, 0); font-size: 10.5pt; line-height: 1.5;"> patch fllow:</span></div><div><span style="background-color: rgba(0, 0, 0, 0); font-size: 10.5pt; line-height: 1.5;"><br></span></div><div><span style="background-color: rgba(0, 0, 0, 0); font-size: 10.5pt; line-height: 1.5;">screenshot:</span></div><div><span style="color: rgb(0, 0, 0); background-color: rgba(0, 0, 0, 0);"><a href="http://7xjcd4.com1.z0.glb.clouddn.com/bog_lo_bug_cell_double_thin_1.png">http://7xjcd4.com1.z0.glb.clouddn.com/bog_lo_bug_cell_double_thin_1.png</a></span></div><div><span style="background-color: rgba(0, 0, 0, 0); font-size: 10.5pt; line-height: 1.5;"><br></span></div><div><span style="background-color: rgba(0, 0, 0, 0); font-size: 10.5pt; line-height: 1.5;">patch:</span></div><div><span></span><span style="color: rgb(0, 0, 0); background-color: rgba(0, 0, 0, 0);">From f7d4b14cccb20ea39a90fb68986fb5578c6fd9a2 Mon Sep 17 00:00:00 2001<br>From: aqcoder <<a href="mailto:flw.aquarius@gmail.com">flw.aquarius@gmail.com</a>><br>Date: Sun, 13 Dec 2015 19:11:28 +0800<br>Subject: [PATCH] fix paint table border in DOUBLE_THIN style<br><br>it always paint partial table border which have line style of DOUBLE_THIN.<br>Becouse the partial of the border line is out of the invalid window rect.<br>so, we extend it.<br><br>Change-Id: I9d95ca71a96cfa869c68d9d2200f29c7cd447eca<br>---<br> sw/source/core/layout/paintfrm.cxx | 18 ++++++++++++++++++<br> 1 file changed, 18 insertions(+)<br><br>diff --git a/sw/source/core/layout/paintfrm.cxx b/sw/source/core/layout/paintfrm.cxx<br>index 83a8638..9746df7 100644<br>--- a/sw/source/core/layout/paintfrm.cxx<br>+++ b/sw/source/core/layout/paintfrm.cxx<br>@@ -2742,6 +2742,24 @@ void SwTabFramePainter::PaintLines(OutputDevice& rDev, const SwRect& rRect) cons<br> aPaintEnd.Y() += static_cast<long>(offsetEnd + 0.5);<br> }<br> <br>+ if( rEntryStyle.Type() == table::BorderLineStyle::DOUBLE_THIN )<br>+ {<br>+ long aPixel = rDev.PixelToLogic( Point(1, 1) ).getX();<br>+ SwRect aPaintEx( aPaintStart, aPaintEnd );<br>+ if( bHori )<br>+ {<br>+ aPaintEx.Pos().Y() -= aPixel;<br>+ aPaintEx.SSize().Height() += aPixel * 2;<br>+ }<br>+ else<br>+ {<br>+ aPaintEx.Pos().X() -= aPixel;<br>+ aPaintEx.SSize().Width() += aPixel * 2;<br>+ }<br>+<br>+ gProp.pSGlobalShell->InvalidateWindows( aPaintEx );<br>+ }<br>+<br> if (bHori)<br> {<br> mrTabFrame.ProcessPrimitives( svx::frame::CreateBorderPrimitives(<br>-- <br>2.5.0</span></div> </div></div></blockquote> </div></blockquote><blockquote type="cite"><div><span>_______________________________________________</span><br><span>LibreOffice mailing list</span><br><span><a href="mailto:LibreOffice@lists.freedesktop.org">LibreOffice@lists.freedesktop.org</a></span><br><span><a href="http://lists.freedesktop.org/mailman/listinfo/libreoffice">http://lists.freedesktop.org/mailman/listinfo/libreoffice</a></span><br></div></blockquote></body></html>