[Libva] "va/va_trace.c" patch for review

Osin, Alexander I alexander.i.osin at intel.com
Thu Jun 9 00:50:24 PDT 2011


	Hi,
	May I suggest simple patch of "va/va_trace.c", please?

There are:
a)	Added prints for new fields of h.264 structures.
b)	Corrected print format for some h.264 values.
c)	Added print for new field of VC1 structure.
d)	Added "fflush" in key points of trace functions (overhead is min). It would help to localize hangs in libva.
e)	Replaced '\t' from C-source code by '     ' spaces.
f)	Updated Copyright from 2009 to 2009-2011.

One comment about (e). I didn't change code style, of course. 99% code lines use "spaces" for shift.
But 'tab' is used sometimes. It's the typical situation for occasional changes in different text editors. That's why I changed some lines.

There are two situations  ('.' - space, '\t' - tabulation):
1)
. . . . . . . . if (bla-bla-bla)			. . . . . . . . if (bla-bla-bla)
. . . . \t \t i ++;			------>	. . . . . . . . . . . . i++;

2)
int function(int a, \t \t /* IN */			int function(int a, . . . . /* IN */
             int b, . . . . \t /* IN */ ---->	             int b, . . . . /* IN */
             int c  \t \t /* IN */				       int c  . . . . /* IN */
            )

(Was it occasional misprints in "va_trace.c"?)

If you are "ok" then could you commit my patch in master, please?

Thanks,
Alexander


--------------------------------------------------------------------
Closed Joint Stock Company Intel A/O
Registered legal address: Krylatsky Hills Business Park, 
17 Krylatskaya Str., Bldg 4, Moscow 121614, 
Russian Federation

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Corrected-trace-prints-updated-change-format-etc-rep.patch
Type: application/octet-stream
Size: 23321 bytes
Desc: 0002-Corrected-trace-prints-updated-change-format-etc-rep.patch
URL: <http://lists.freedesktop.org/archives/libva/attachments/20110609/f9e21541/attachment-0001.obj>


More information about the Libva mailing list