[Libva] JPEG decoding API

Xiang, Haihao haihao.xiang at intel.com
Mon Oct 10 18:56:09 PDT 2011


On Sat, 2011-10-08 at 15:30 +0800, Gwenole Beauchesne wrote: 
> Hi,
> 
> I would suggest the following changes:
> 
> 1. Remove the VA_JPEG_ROTATION_* definitions. They are the same as the
> current VA_ROTATION_* definitions used as display attributes. Besides,
> even if they were not, we could still use them an remap accordingly in
> the driver.
> 2. s/count_in_mcus/num_mcus/ to retain the num_* coding style?

I'm fine with these modifications.

> 
> 3. Is there a reason not to make slice params components[] refer to
> the component ids directly?
The backend driver doesn't need to search for component parameters and
it also indicates that each component in SOS must match one of component
in SOF. 

Thanks
Haihao




More information about the Libva mailing list