[Libva] Fwd: FGLRX detection code overly restrictive

Stephan Diestelhorst stephan.diestelhorst at gmail.com
Tue Oct 11 02:45:49 PDT 2011


On Tue, Oct 11, 2011 at 11:21 AM, Gwenole Beauchesne <gb.devel at gmail.com> wrote:
> Hi,
>
>> Thanks for the patch. I will have a look at it tomorrow. The success =
>> (*driver_name != NULL) is definitely the right option. I might fix the
>> display problem differently though, depending on how much information
>> ADL can provide.
>
> I pushed a fix to git master. Please test.

Works, great!

Manual inspection shows however, that your code also would tolerate different
screens than ".0" to be equal to the omitted one, which is different from my
patch.

And well.. it ain't much nicer than what I had, IMHO :-) But that is just C and
clumsy string handling.

Stephan


More information about the Libva mailing list