[Libva] [android-build v2 3/3] android-test: compile tests for all android versions

Gwenole Beauchesne gb.devel at gmail.com
Mon Aug 20 14:33:52 PDT 2012


Hi,

2012/8/17 Daniel Charles <daniel.charles at intel.com>:
> +#ifdef ANDROID_PRE_JB
>  #include <surfaceflinger/ISurfaceComposer.h>
>  #include <surfaceflinger/Surface.h>
>  #include <surfaceflinger/ISurface.h>
>  #include <surfaceflinger/SurfaceComposerClient.h>
> +#elif ANDROID_JB
> +#include <gui/ISurfaceComposer.h>
> +#include <gui/Surface.h>
> +#include <gui/ISurface.h>
> +#include <gui/SurfaceComposerClient.h>
> +#endif
>  #include <binder/MemoryHeapBase.h>

I would prefer a more generic ANDROID_CHECK_VERSION() macro. e.g.
#if ANDROID_CHECK_VERSION(4,1,0)
...
#else
...
#endif

by probably decomposing PLATFORM_VERSION into major/minor/micro.

Thanks,
Gwenole.


More information about the Libva mailing list