[Libva] regression from 1.2: ivybridge + i965/libva=1.3 decodes solid black with mpv --hwdec=vaapi --vo=opengl

[Xiang, Haihao]

I verified Rinat's patch works with older version of xorg-server. I will
push Rinat's patch with a little change to the requirement on depth
buffer in case people still use an older version of xorg-server.

Thanks
Haihao


> The libva commit b4a4f9b212d8b0bf41a910a85a4898573261d2a7 removes the
> requirement on GLX_DEPTH_SIZE, which exposes a bug in Xserver/GLX, see
> the comment #18 at https://bugs.freedesktop.org/show_bug.cgi?id=76755.
> Upgrading xorg-sever to 1.15.1 or 1.15.99.902 (1.16.0 RC 2) can resolve
> this issue.
> 
> Thanks
> Haihao
> 
> 
> 
> > Hi, Rinat
> > 
> > Thanks for your patch although I don't think a Depth buffer is needed in
> > VA GLX.
> > 
> > Hi, Kevin
> > 
> > Could you give a try with Rinat's patch ? It always works for me w/wo
> > Rinat's patch.
> > 
> > Thanks
> > Haihao
> > 
> > 
> > 
> > > Sun, 6 Apr 2014 04:40:51 -0700 от Kevin Mitchell <kevmitch at gmail.com>:
> > > > 
> > > > This poroblem is only exhibited on an Ivy Bridge machine. A comparably configured Sandy Bridge machine decodes as expected with the first command in all cases.
> > > > 
> > > > Any Ideas?
> > > 
> > > I have the same issue on Ivybridge machine. It was started with Mesa upgrade to 10.1 (in Debian).
> > > Don't know why, but it's somehow affected by GLX depth buffer. And this patch at least hides an issue:
> > > 
> > > diff -ur libva-1.3.0-orig/va/glx/va_glx_impl.c libva-1.3.0/va/glx/va_glx_impl.c
> > > --- libva-1.3.0-orig/va/glx/va_glx_impl.c	2014-03-24 12:03:33.000000000 +0400
> > > +++ libva-1.3.0/va/glx/va_glx_impl.c	2014-04-11 10:59:48.000000000 +0400
> > > @@ -500,6 +500,7 @@
> > >          GLX_RED_SIZE,           8,
> > >          GLX_GREEN_SIZE,         8,
> > >          GLX_BLUE_SIZE,          8,
> > > +        GLX_DEPTH_SIZE,         24,
> > >          GL_NONE,
> > >      };
> > >      for (attrib = fbconfig_attrs; *attrib != GL_NONE; attrib += 2)
> > > 
> > > 
> > > > 
> > > > Kevin
> > > > 
> > > > [1]  http://mpv.io/
> > > > Debian Bug #743701  https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=%23743701
> > > > 
> > > 
> > > ---
> > > Rinat
> > > _______________________________________________
> > > Libva mailing list
> > > Libva at lists.freedesktop.org
> > > http://lists.freedesktop.org/mailman/listinfo/libva
> > 
> 
> 
> _______________________________________________
> Libva mailing list
> Libva at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libva