[Libva] [PATCH 7/7] va: hide most private va_Trace* symbols

Emil Velikov emil.l.velikov at gmail.com
Thu Sep 18 09:30:32 PDT 2014


Hide all but va_TracePutSurface symbols from the user.
The latter one is used internally by va_x11 and va_android.

Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>
---
 va/va_fool.c  |  1 +
 va/va_trace.c |  6 +++---
 va/va_trace.h | 26 ++++++++++++++++++++++++--
 3 files changed, 28 insertions(+), 5 deletions(-)

diff --git a/va/va_fool.c b/va/va_fool.c
index 9f7a045..8dbe8dd 100644
--- a/va/va_fool.c
+++ b/va/va_fool.c
@@ -23,6 +23,7 @@
  */
 
 #define _GNU_SOURCE 1
+#include "sysdeps.h"
 #include "va.h"
 #include "va_backend.h"
 #include "va_trace.h"
diff --git a/va/va_trace.c b/va/va_trace.c
index 910ecb6..c95228a 100644
--- a/va/va_trace.c
+++ b/va/va_trace.c
@@ -24,6 +24,7 @@
  */
 
 #define _GNU_SOURCE 1
+#include "sysdeps.h"
 #include "va.h"
 #include "va_enc_h264.h"
 #include "va_backend.h"
@@ -257,8 +258,7 @@ void va_TraceEnd(VADisplay dpy)
     ((VADisplayContextP)dpy)->vatrace = NULL;
 }
 
-
-void va_TraceMsg(struct trace_context *trace_ctx, const char *msg, ...)
+static void va_TraceMsg(struct trace_context *trace_ctx, const char *msg, ...)
 {
     va_list args;
 
@@ -279,7 +279,7 @@ void va_TraceMsg(struct trace_context *trace_ctx, const char *msg, ...)
 }
 
 
-void va_TraceSurface(VADisplay dpy)
+static void va_TraceSurface(VADisplay dpy)
 {
     unsigned int i, j;
     unsigned int fourcc; /* following are output argument */
diff --git a/va/va_trace.h b/va/va_trace.h
index d002e49..141e7c3 100644
--- a/va/va_trace.h
+++ b/va/va_trace.h
@@ -50,19 +50,24 @@ extern int trace_flag;
         trace_func(__VA_ARGS__);                \
     }
 
+DLL_HIDDEN
 void va_TraceInit(VADisplay dpy);
+DLL_HIDDEN
 void va_TraceEnd(VADisplay dpy);
 
+DLL_HIDDEN
 void va_TraceInitialize (
     VADisplay dpy,
     int *major_version,	 /* out */
     int *minor_version 	 /* out */
 );
 
+DLL_HIDDEN
 void va_TraceTerminate (
     VADisplay dpy
 );
 
+DLL_HIDDEN
 void va_TraceCreateConfig(
     VADisplay dpy,
     VAProfile profile, 
@@ -72,6 +77,7 @@ void va_TraceCreateConfig(
     VAConfigID *config_id /* out */
 );
 
+DLL_HIDDEN
 void va_TraceCreateSurfaces(
     VADisplay dpy,
     int width,
@@ -83,12 +89,14 @@ void va_TraceCreateSurfaces(
     unsigned int        num_attribs
 );
 
+DLL_HIDDEN
 void va_TraceDestroySurfaces(
     VADisplay dpy,
     VASurfaceID *surface_list,
     int num_surfaces
 );
-    
+
+DLL_HIDDEN
 void va_TraceCreateContext(
     VADisplay dpy,
     VAConfigID config_id,
@@ -100,6 +108,7 @@ void va_TraceCreateContext(
     VAContextID *context		/* out */
 );
 
+DLL_HIDDEN
 void va_TraceCreateBuffer (
     VADisplay dpy,
     VAContextID context,	/* in */
@@ -109,12 +118,14 @@ void va_TraceCreateBuffer (
     void *data,			/* in */
     VABufferID *buf_id		/* out */
 );
-    
+
+DLL_HIDDEN
 void va_TraceDestroyBuffer (
     VADisplay dpy,
     VABufferID buf_id    /* in */
 );
 
+DLL_HIDDEN
 void va_TraceMapBuffer (
     VADisplay dpy,
     VABufferID buf_id,	/* in */
@@ -122,12 +133,14 @@ void va_TraceMapBuffer (
 );
 
 
+DLL_HIDDEN
 void va_TraceBeginPicture(
     VADisplay dpy,
     VAContextID context,
     VASurfaceID render_target
 );
 
+DLL_HIDDEN
 void va_TraceRenderPicture(
     VADisplay dpy,
     VAContextID context,
@@ -135,17 +148,20 @@ void va_TraceRenderPicture(
     int num_buffers
 );
 
+DLL_HIDDEN
 void va_TraceEndPicture(
     VADisplay dpy,
     VAContextID context,
     int endpic_done
 );
 
+DLL_HIDDEN
 void va_TraceSyncSurface(
     VADisplay dpy,
     VASurfaceID render_target
 );
 
+DLL_HIDDEN
 void va_TraceQuerySurfaceAttributes(
     VADisplay           dpy,
     VAConfigID          config,
@@ -153,12 +169,14 @@ void va_TraceQuerySurfaceAttributes(
     unsigned int       *num_attribs
 );
 
+DLL_HIDDEN
 void va_TraceQuerySurfaceStatus(
     VADisplay dpy,
     VASurfaceID render_target,
     VASurfaceStatus *status	/* out */
 );
 
+DLL_HIDDEN
 void va_TraceQuerySurfaceError(
 	VADisplay dpy,
 	VASurfaceID surface,
@@ -167,23 +185,27 @@ void va_TraceQuerySurfaceError(
 );
 
 
+DLL_HIDDEN
 void va_TraceMaxNumDisplayAttributes (
     VADisplay dpy,
     int number
 );
 
+DLL_HIDDEN
 void va_TraceQueryDisplayAttributes (
     VADisplay dpy,
     VADisplayAttribute *attr_list,	/* out */
     int *num_attributes			/* out */
 );
 
+DLL_HIDDEN
 void va_TraceGetDisplayAttributes (
     VADisplay dpy,
     VADisplayAttribute *attr_list,
     int num_attributes
 );
 
+DLL_HIDDEN
 void va_TraceSetDisplayAttributes (
     VADisplay dpy,
     VADisplayAttribute *attr_list,
-- 
2.1.0



More information about the Libva mailing list