<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On May 19, 2015, at 17:36, Eoff, Ullysses A <<a href="mailto:ullysses.a.eoff@intel.com" class="">ullysses.a.eoff@intel.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">On Tue, 2015-05-19 at 15:30 -0700, Sean V Kelley wrote:</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><blockquote type="cite" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">Artie,<br class=""><br class=""><blockquote type="cite" class="">On May 19, 2015, at 14:59, U. Artie Eoff <<a href="mailto:ullysses.a.eoff@intel.com" class="">ullysses.a.eoff@intel.com</a>> wrote:<br class=""><br class="">This is a follow up to previous commit:<br class=""><br class="">commit 8dda0650b55c467200c34ada127b5d9b54edea5c<br class="">Author: Zhao Yakui <<a href="mailto:yakui.zhao@intel.com" class="">yakui.zhao@intel.com</a>><br class="">Date: Tue May 5 17:56:38 2015 +0800<br class=""><br class=""></blockquote><br class=""><br class="">Please resubmit your patch, with you as author as you are accounting for the GEN8 case<br class="">of inadvertent WA enabling. GEN7 changes are already merged.<br class=""><br class="">Thanks,<br class=""><br class="">Sean<br class=""><br class=""></blockquote><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">This patch already has me as author. The above is just a reference in</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">the "commit message" to the original GEN7 case.</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""></div></blockquote><div><br class=""></div><div><br class=""></div><div>You’re right. I was seeing the comment. Applied to master, thanks.</div><div><br class=""></div><div>Sean</div><br class=""><blockquote type="cite" class=""><div class=""><blockquote type="cite" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><br class=""><blockquote type="cite" class=""> Decode: Free the allocated internal surface used by JPEG to avoid memory leak<br class=""><br class="">For GEN8, this code path is normally disabled by default.<br class="">However, one can enable this code path by defining JPEG_WA<br class="">during compilation. In that case, we would enable the<br class="">same memory leak. Thus, apply the same fix in gen8_mfd to<br class="">fix it.<br class=""><br class="">Signed-off-by: U. Artie Eoff <<a href="mailto:ullysses.a.eoff@intel.com" class="">ullysses.a.eoff@intel.com</a>><br class="">---<br class="">src/gen8_mfd.c | 12 ++++++++++++<br class="">1 file changed, 12 insertions(+)<br class=""><br class="">diff --git a/src/gen8_mfd.c b/src/gen8_mfd.c<br class="">index 6618740..f045ca4 100644<br class="">--- a/src/gen8_mfd.c<br class="">+++ b/src/gen8_mfd.c<br class="">@@ -3112,8 +3112,11 @@ out:<br class="">static void<br class="">gen8_mfd_context_destroy(void *hw_context)<br class="">{<br class="">+ VADriverContextP ctx;<br class=""> struct gen7_mfd_context *gen7_mfd_context = (struct gen7_mfd_context *)hw_context;<br class=""><br class="">+ ctx = (VADriverContextP)(gen7_mfd_context->driver_context);<br class="">+<br class=""> dri_bo_unreference(gen7_mfd_context->post_deblocking_output.bo);<br class=""> gen7_mfd_context->post_deblocking_output.bo = NULL;<br class=""><br class="">@@ -3140,6 +3143,13 @@ gen8_mfd_context_destroy(void *hw_context)<br class=""><br class=""> dri_bo_unreference(gen7_mfd_context->jpeg_wa_slice_data_bo);<br class=""><br class="">+ if (gen7_mfd_context->jpeg_wa_surface_id != VA_INVALID_SURFACE) {<br class="">+ i965_DestroySurfaces(ctx,<br class="">+ &gen7_mfd_context->jpeg_wa_surface_id,<br class="">+ 1);<br class="">+ gen7_mfd_context->jpeg_wa_surface_object = NULL;<br class="">+ }<br class="">+<br class=""> intel_batchbuffer_free(gen7_mfd_context->base.batch);<br class=""> free(gen7_mfd_context);<br class="">}<br class="">@@ -3188,5 +3198,7 @@ gen8_dec_hw_context_init(VADriverContextP ctx, struct object_config *obj_config)<br class=""> default:<br class=""> break;<br class=""> }<br class="">+<br class="">+ gen7_mfd_context->driver_context = ctx;<br class=""> return (struct hw_context *)gen7_mfd_context;<br class="">}<br class="">--<span class="Apple-converted-space"> </span><br class="">1.9.3<br class=""><br class="">_______________________________________________<br class="">Libva mailing list<br class=""><a href="mailto:Libva@lists.freedesktop.org" class="">Libva@lists.freedesktop.org</a><br class="">http://lists.freedesktop.org/mailman/listinfo/libva</blockquote></blockquote></div></blockquote></div><br class=""></body></html>