Mesa (master): mesa: issue error, don't crash, when calling a prototyped, but undefined function

Brian Paul brianp at kemper.freedesktop.org
Sat Nov 22 00:23:01 UTC 2008


Module: Mesa
Branch: master
Commit: 4f05893415a2d6f29b29f4daf991ea95a1891a81
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=4f05893415a2d6f29b29f4daf991ea95a1891a81

Author: Brian Paul <brian.paul at tungstengraphics.com>
Date:   Fri Nov 21 17:22:16 2008 -0700

mesa: issue error, don't crash, when calling a prototyped, but undefined function

Bug #18659.

---

 src/mesa/shader/slang/slang_codegen.c |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/src/mesa/shader/slang/slang_codegen.c b/src/mesa/shader/slang/slang_codegen.c
index 882a653..0dacfee 100644
--- a/src/mesa/shader/slang/slang_codegen.c
+++ b/src/mesa/shader/slang/slang_codegen.c
@@ -2020,6 +2020,13 @@ _slang_gen_function_call_name(slang_assemble_ctx *A, const char *name,
                            name);
       return NULL;
    }
+   if (!fun->body) {
+      slang_info_log_error(A->log,
+                           "Function '%s' prototyped but not defined.  "
+                           "Separate compilation units not supported.",
+                           name);
+      return NULL;
+   }
 
    n = _slang_gen_function_call(A, fun, oper, dest);
 




More information about the mesa-commit mailing list