Mesa (master): dri glx: Swap before checking for cliprects.

Younes Manton ymanton at kemper.freedesktop.org
Tue Apr 14 01:35:07 UTC 2009


Module: Mesa
Branch: master
Commit: 43c7ffaea635f949fd4803c4f594cf53e4b98f24
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=43c7ffaea635f949fd4803c4f594cf53e4b98f24

Author: Younes Manton <younes.m at gmail.com>
Date:   Mon Apr 13 21:24:44 2009 -0400

dri glx: Swap before checking for cliprects.

We don't update drawables anymore unless they are completely
uninitialized, so we need to swap even if we don't have
cliprects yet, otherwise we never end up calling the driver's
SwapBuffers(). The driver should update the drawable in its
SwapBuffers() anyway.

See 8e753d04045a82062ac34d3b2622eb9dba8af374,
"dri glx: Fix dri_util::driBindContext" for the change that
exposed it.

---

 src/mesa/drivers/dri/common/dri_util.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/mesa/drivers/dri/common/dri_util.c b/src/mesa/drivers/dri/common/dri_util.c
index 38c2e7b..f620c26 100644
--- a/src/mesa/drivers/dri/common/dri_util.c
+++ b/src/mesa/drivers/dri/common/dri_util.c
@@ -311,12 +311,12 @@ static void driSwapBuffers(__DRIdrawable *dPriv)
     __DRIscreen *psp = dPriv->driScreenPriv;
     drm_clip_rect_t *rects;
     int i;
-    
-    if (!dPriv->numClipRects)
-        return;
 
     psp->DriverAPI.SwapBuffers(dPriv);
 
+    if (!dPriv->numClipRects)
+        return;
+
     rects = _mesa_malloc(sizeof(*rects) * dPriv->numClipRects);
 
     if (!rects)




More information about the mesa-commit mailing list