Mesa (master): i965: disable using immediate values for MOV instructions

Brian Paul brianp at kemper.freedesktop.org
Thu Apr 16 17:13:44 UTC 2009


Module: Mesa
Branch: master
Commit: 33b865f70dc1461b040c9c436ec8e5a8171f00e7
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=33b865f70dc1461b040c9c436ec8e5a8171f00e7

Author: Brian Paul <brianp at vmware.com>
Date:   Thu Apr 16 11:08:12 2009 -0600

i965: disable using immediate values for MOV instructions

For some reason, MOV instructions using immediate src values don't seem
to work reliably on the GLSL path.  Disable them for now (falling back to
const buffer reads).  This fixes a bunch of glean glsl1 failures.

---

 src/mesa/drivers/dri/i965/brw_wm_glsl.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/brw_wm_glsl.c b/src/mesa/drivers/dri/i965/brw_wm_glsl.c
index 62fa573..634648a 100644
--- a/src/mesa/drivers/dri/i965/brw_wm_glsl.c
+++ b/src/mesa/drivers/dri/i965/brw_wm_glsl.c
@@ -527,7 +527,9 @@ static void emit_mov( struct brw_wm_compile *c,
 	if (mask & (1<<i)) {
 	    struct brw_reg src, dst;
 	    dst = get_dst_reg(c, inst, i);
-	    src = get_src_reg_imm(c, inst, 0, i);
+            /* XXX some moves from immediate value don't work reliably!!! */
+            /*src = get_src_reg_imm(c, inst, 0, i);*/
+            src = get_src_reg(c, inst, 0, i);
 	    brw_MOV(p, dst, src);
 	}
     }




More information about the mesa-commit mailing list