Mesa (master): mklib: replace if/expr with case

Brian Paul brianp at kemper.freedesktop.org
Thu Apr 30 23:04:38 UTC 2009


Module: Mesa
Branch: master
Commit: eef79d50bf160a0278266cac56a915027538ac1e
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=eef79d50bf160a0278266cac56a915027538ac1e

Author: Tormod Volden <debian.tormod at gmail.com>
Date:   Thu Apr 30 16:55:54 2009 -0600

mklib: replace if/expr with case

Saves forking an expr for every object.

---

 bin/mklib |   27 +++++++++++++++------------
 1 files changed, 15 insertions(+), 12 deletions(-)

diff --git a/bin/mklib b/bin/mklib
index db3bc83..2fd95ba 100755
--- a/bin/mklib
+++ b/bin/mklib
@@ -281,18 +281,21 @@ case $ARCH in
 	    # expand any .a objects into constituent .o files.
 	    NEWOBJECTS=""
 	    DELETIA=""
-	    for OBJ in ${OBJECTS} ; do
-		if [ `expr match $OBJ '.*\.a'` -gt 0 ] ; then
-		    # extract the .o files from this .a archive
-		    FILES=`ar t $OBJ`
-		    ar x $OBJ
-		    NEWOBJECTS="$NEWOBJECTS $FILES"
-		    # keep track of temporary .o files and delete them below
-		    DELETIA="$DELETIA $FILES"
-		else
-		    # ordinary .o file
-		    NEWOBJECTS="$NEWOBJECTS $OBJ"
-		fi
+	    for OBJ in $OBJECTS ; do
+		case $OBJ in
+		    *.a)
+			# extract the .o files from this .a archive
+			FILES=`ar t $OBJ`
+			ar x $OBJ
+			NEWOBJECTS="$NEWOBJECTS $FILES"
+			# keep track of temporary .o files and delete them below
+			DELETIA="$DELETIA $FILES"
+			;;
+		    *)
+			# ordinary .o file
+			NEWOBJECTS="$NEWOBJECTS $OBJ"
+			;;
+		esac
 	    done
 
             # make lib




More information about the mesa-commit mailing list