Mesa (master): mesa: _mesa_layout_parameters() returns a boolean value

Brian Paul brianp at kemper.freedesktop.org
Mon Aug 24 17:07:58 UTC 2009


Module: Mesa
Branch: master
Commit: 53db19b57d41a5e6beea5cb5dff4f7f638ca7b50
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=53db19b57d41a5e6beea5cb5dff4f7f638ca7b50

Author: Brian Paul <brianp at vmware.com>
Date:   Mon Aug 24 10:50:07 2009 -0600

mesa: _mesa_layout_parameters() returns a boolean value

---

 src/mesa/shader/prog_parameter_layout.c |   12 ++++++++----
 src/mesa/shader/prog_parameter_layout.h |    3 ++-
 2 files changed, 10 insertions(+), 5 deletions(-)

diff --git a/src/mesa/shader/prog_parameter_layout.c b/src/mesa/shader/prog_parameter_layout.c
index 8f2b306..1c37b3a 100644
--- a/src/mesa/shader/prog_parameter_layout.c
+++ b/src/mesa/shader/prog_parameter_layout.c
@@ -106,7 +106,11 @@ copy_indirect_accessed_array(struct gl_program_parameter_list *src,
 }
 
 
-int
+/**
+ * XXX description???
+ * \return GL_TRUE for success, GL_FALSE for failure
+ */
+GLboolean
 _mesa_layout_parameters(struct asm_parser_state *state)
 {
    struct gl_program_parameter_list *layout;
@@ -128,12 +132,12 @@ _mesa_layout_parameters(struct asm_parser_state *state)
 	     */
 	    if (!inst->SrcReg[i].Symbol->pass1_done) {
 	       const int new_begin =
-		  copy_indirect_accessed_array(state->prog->Parameters, layout, 
+		  copy_indirect_accessed_array(state->prog->Parameters, layout,
 		      inst->SrcReg[i].Symbol->param_binding_begin,
 		      inst->SrcReg[i].Symbol->param_binding_length);
 
 	       if (new_begin < 0) {
-		  return 0;
+		  return GL_FALSE;
 	       }
 
 	       inst->SrcReg[i].Symbol->param_binding_begin = new_begin;
@@ -209,5 +213,5 @@ _mesa_layout_parameters(struct asm_parser_state *state)
    _mesa_free_parameter_list(state->prog->Parameters);
    state->prog->Parameters = layout;
 
-   return 1;
+   return GL_TRUE;
 }
diff --git a/src/mesa/shader/prog_parameter_layout.h b/src/mesa/shader/prog_parameter_layout.h
index 1686170..99a7b6c 100644
--- a/src/mesa/shader/prog_parameter_layout.h
+++ b/src/mesa/shader/prog_parameter_layout.h
@@ -36,6 +36,7 @@
 extern unsigned _mesa_combine_swizzles(unsigned base, unsigned applied);
 
 struct asm_parser_state;
-extern int _mesa_layout_parameters(struct asm_parser_state *state);
+
+extern GLboolean _mesa_layout_parameters(struct asm_parser_state *state);
 
 #endif /* PROG_PARAMETER_LAYOUT_H */




More information about the mesa-commit mailing list