Mesa (lp-binning): llvmpipe: minor refactoring of bin rasterization code

Brian Paul brianp at kemper.freedesktop.org
Tue Dec 1 11:27:40 PST 2009


Module: Mesa
Branch: lp-binning
Commit: 7d042ac2a285c220a396d91a6dbe5c7f4e697c71
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=7d042ac2a285c220a396d91a6dbe5c7f4e697c71

Author: Brian Paul <brianp at vmware.com>
Date:   Mon Nov 30 14:01:31 2009 -0700

llvmpipe: minor refactoring of bin rasterization code

---

 src/gallium/drivers/llvmpipe/lp_setup.c |   44 +++++++++++++++++++-----------
 1 files changed, 28 insertions(+), 16 deletions(-)

diff --git a/src/gallium/drivers/llvmpipe/lp_setup.c b/src/gallium/drivers/llvmpipe/lp_setup.c
index 6d84147..7091232 100644
--- a/src/gallium/drivers/llvmpipe/lp_setup.c
+++ b/src/gallium/drivers/llvmpipe/lp_setup.c
@@ -170,13 +170,35 @@ static void bin_everywhere( struct setup_context *setup,
 }
 
 
+/** Rasterize commands for a single bin */
+static void
+rasterize_bin( struct lp_rasterizer *rast,
+               struct cmd_block_list *commands,
+               int x, int y)
+{
+   struct cmd_block *block;
+   unsigned k;
+
+   lp_rast_start_tile( rast, x, y );
+
+   /* simply execute each of the commands in the block list */
+   for (block = commands->head; block; block = block->next) {
+      for (k = 0; k < block->count; k++) {
+         block->cmd[k]( rast, block->arg[k] );
+      }
+   }
+
+   lp_rast_end_tile( rast );
+}
+
+
+/** Rasterize all tile's bins */
 static void
 rasterize_bins( struct setup_context *setup,
                 boolean write_depth )
 {
    struct lp_rasterizer *rast = setup->rast;
-   struct cmd_block *block;
-   unsigned i,j,k;
+   unsigned i, j;
 
    SETUP_DEBUG("%s\n", __FUNCTION__);
 
@@ -187,23 +209,13 @@ rasterize_bins( struct setup_context *setup,
                   setup->fb.zsbuf != NULL && write_depth,
                   setup->fb.width,
                   setup->fb.height );
-
                        
-
+   /* loop over tile bins, rasterize each */
    for (i = 0; i < setup->tiles_x; i++) {
       for (j = 0; j < setup->tiles_y; j++) {
-
-         lp_rast_start_tile( rast, 
-                             i * TILE_SIZE,
-                             j * TILE_SIZE );
-
-         for (block = setup->tile[i][j].head; block; block = block->next) {
-            for (k = 0; k < block->count; k++) {
-               block->cmd[k]( rast, block->arg[k] );
-            }
-         }
-
-         lp_rast_end_tile( rast );
+         rasterize_bin( rast, &setup->tile[i][j], 
+                        i * TILE_SIZE,
+                        j * TILE_SIZE );
       }
    }
 



More information about the mesa-commit mailing list