Mesa (master): i965: fix line stipple fallback for GL_LINE_STRIP primitives

Robert Ellison papillo at kemper.freedesktop.org
Mon Feb 23 10:28:30 PST 2009


Module: Mesa
Branch: master
Commit: 73658ff04fd4cb5f492b0477775430efc5f8b4ca
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=73658ff04fd4cb5f492b0477775430efc5f8b4ca

Author: Robert Ellison <papillo at vmware.com>
Date:   Fri Feb 20 17:04:15 2009 -0700

i965: fix line stipple fallback for GL_LINE_STRIP primitives

When doing line stipple, the stipple count resets on each line segment,
unless the primitive is a GL_LINE_LOOP or a GL_LINE_STRIP.

The existing code correctly identifies the need for a software fallback
to handle conformant line stipple on GL_LINE_LOOP primitives, but
neglects to make the same assessment on GL_LINE_STRIP primitives.
This fixes it so they match.

---

 src/mesa/drivers/dri/i965/brw_draw.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/brw_draw.c b/src/mesa/drivers/dri/i965/brw_draw.c
index 99fd587..3ca953d 100644
--- a/src/mesa/drivers/dri/i965/brw_draw.c
+++ b/src/mesa/drivers/dri/i965/brw_draw.c
@@ -220,7 +220,7 @@ static GLboolean check_fallbacks( struct brw_context *brw,
 	 /* GS doesn't get enough information to know when to reset
 	  * the stipple counter?!?
 	  */
-	 if (prim[i].mode == GL_LINE_LOOP) 
+	 if (prim[i].mode == GL_LINE_LOOP || prim[i].mode == GL_LINE_STRIP) 
 	    return GL_TRUE;
 	    
 	 if (prim[i].mode == GL_POLYGON &&



More information about the mesa-commit mailing list