Mesa (intel-2008-q4): mesa: fix bug in evaluation of structure fields

Haihao Xiang haihao at kemper.freedesktop.org
Mon Jan 5 08:06:23 UTC 2009


Module: Mesa
Branch: intel-2008-q4
Commit: 41a9768b1037da9bb9246de068ebc5d2392197ad
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=41a9768b1037da9bb9246de068ebc5d2392197ad

Author: Brian Paul <brianp at vmware.com>
Date:   Tue Dec 30 17:50:39 2008 -0700

mesa: fix bug in evaluation of structure fields

Fixes incorrect size information.  See bug 19273.
(cherry picked from commit e8d7db31e2a6784c765911233cb3d888f612837f)

---

 src/mesa/shader/slang/slang_emit.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/src/mesa/shader/slang/slang_emit.c b/src/mesa/shader/slang/slang_emit.c
index e3cb252..08230f0 100644
--- a/src/mesa/shader/slang/slang_emit.c
+++ b/src/mesa/shader/slang/slang_emit.c
@@ -1963,9 +1963,7 @@ emit_struct_field(slang_emit_info *emitInfo, slang_ir_node *n)
    _slang_copy_ir_storage(n->Store, n->Children[0]->Store);
 
    n->Store->Index = n->Children[0]->Store->Index + fieldOffset / 4;
-   /* XXX test this:
-   n->Store->Index += fieldOffset / 4;
-   */
+   n->Store->Size = fieldSize;
 
    switch (fieldSize) {
    case 1:




More information about the mesa-commit mailing list