Mesa (master): dri2: add complaints for more initialization failures.

Eric Anholt anholt at kemper.freedesktop.org
Tue Jan 27 22:39:12 UTC 2009


Module: Mesa
Branch: master
Commit: 0f72de55386c391c4cc3ee346216f09152a6b5ab
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=0f72de55386c391c4cc3ee346216f09152a6b5ab

Author: Eric Anholt <eric at anholt.net>
Date:   Tue Jan 27 14:34:29 2009 -0800

dri2: add complaints for more initialization failures.

Somehow we're running into DRI2Authenticate failing, and silent demotion to
swrast is bad.

---

 src/glx/x11/dri2_glx.c |   12 +++++++++---
 1 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/src/glx/x11/dri2_glx.c b/src/glx/x11/dri2_glx.c
index 2bee677..d16f809 100644
--- a/src/glx/x11/dri2_glx.c
+++ b/src/glx/x11/dri2_glx.c
@@ -282,8 +282,10 @@ static __GLXDRIscreen *dri2CreateScreen(__GLXscreenConfigs *psc, int screen,
 	return NULL;
 
     psc->driver = driOpenDriver(driverName);
-    if (psc->driver == NULL)
+    if (psc->driver == NULL) {
+	ErrorMessageF("driver pointer missing\n");
 	goto handle_error;
+    }
 
     extensions = dlsym(psc->driver, __DRI_DRIVER_EXTENSIONS);
     if (extensions == NULL) {
@@ -309,11 +311,15 @@ static __GLXDRIscreen *dri2CreateScreen(__GLXscreenConfigs *psc, int screen,
 	return NULL;
     }
 
-    if (drmGetMagic(psc->fd, &magic))
+    if (drmGetMagic(psc->fd, &magic)) {
+	ErrorMessageF("failed to get magic\n");
 	return NULL;
+    }
 
-    if (!DRI2Authenticate(psc->dpy, RootWindow(psc->dpy, screen), magic))
+    if (!DRI2Authenticate(psc->dpy, RootWindow(psc->dpy, screen), magic)) {
+	ErrorMessageF("failed to authenticate magic %d\n", magic);
 	return NULL;
+    }
 
     psc->__driScreen = 
 	psc->dri2->createNewScreen(screen, psc->fd,




More information about the mesa-commit mailing list