Mesa (master): radeon: fix unsigned vs signed comparison in stencil code.

Dave Airlie airlied at kemper.freedesktop.org
Tue Jul 14 22:24:16 UTC 2009


Module: Mesa
Branch: master
Commit: 681ede8836746735fbb904edf89b076343507a8b
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=681ede8836746735fbb904edf89b076343507a8b

Author: Dave Airlie <airlied at redhat.com>
Date:   Wed Jul 15 07:10:45 2009 +1000

radeon: fix unsigned vs signed comparison in stencil code.

This function takes a GLint not a GLuint, passing in -1
breaks internally.

---

 src/mesa/drivers/dri/radeon/radeon_common.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/mesa/drivers/dri/radeon/radeon_common.c b/src/mesa/drivers/dri/radeon/radeon_common.c
index 0853518..0a8d8b0 100644
--- a/src/mesa/drivers/dri/radeon/radeon_common.c
+++ b/src/mesa/drivers/dri/radeon/radeon_common.c
@@ -1482,7 +1482,7 @@ void radeon_clear_tris(GLcontext *ctx, GLbitfield mask)
       if (this_mask & BUFFER_BIT_STENCIL) {
 	 _mesa_Enable(GL_STENCIL_TEST);
 	 _mesa_StencilOp(GL_REPLACE, GL_REPLACE, GL_REPLACE);
-	 _mesa_StencilFuncSeparate(GL_FRONT_AND_BACK, GL_ALWAYS, ctx->Stencil.Clear,
+	 _mesa_StencilFuncSeparate(GL_FRONT_AND_BACK, GL_ALWAYS, (GLint)ctx->Stencil.Clear,
 				   ctx->Stencil.WriteMask[0]);
       } else {
 	 _mesa_Disable(GL_STENCIL_TEST);




More information about the mesa-commit mailing list