Mesa (master): r300g: Actually mark shaders as translated/untranslated.

Corbin Simpson csimpson at kemper.freedesktop.org
Thu Jul 23 07:00:57 UTC 2009


Module: Mesa
Branch: master
Commit: 07961bb05e5ba05205b9f53834863664f1023870
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=07961bb05e5ba05205b9f53834863664f1023870

Author: Corbin Simpson <MostAwesomeDude at gmail.com>
Date:   Wed Jul 22 23:58:35 2009 -0700

r300g: Actually mark shaders as translated/untranslated.

Also trust that Gallium will not give us TGSI that miscounts shader consts.

This creates a 20x speedup on glxgears, from 8 FPS to 160 FPS.

---

 src/gallium/drivers/r300/r300_fs.c    |    3 +++
 src/gallium/drivers/r300/r300_state.c |    4 ++--
 src/gallium/drivers/r300/r300_vs.c    |    3 +++
 3 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/src/gallium/drivers/r300/r300_fs.c b/src/gallium/drivers/r300/r300_fs.c
index 8672e21..ca8ef99 100644
--- a/src/gallium/drivers/r300/r300_fs.c
+++ b/src/gallium/drivers/r300/r300_fs.c
@@ -105,4 +105,7 @@ void r300_translate_fragment_shader(struct r300_context* r300,
 
     tgsi_parse_free(&parser);
     FREE(assembler);
+
+    /* And, finally... */
+    fs->translated = TRUE;
 }
diff --git a/src/gallium/drivers/r300/r300_state.c b/src/gallium/drivers/r300/r300_state.c
index 68da0aa..162740f 100644
--- a/src/gallium/drivers/r300/r300_state.c
+++ b/src/gallium/drivers/r300/r300_state.c
@@ -155,7 +155,7 @@ static void
     }
 
     r300->dirty_state |= R300_NEW_CONSTANTS;
-
+#if 0
     /* If the number of constants have changed, invalidate the shader. */
     if (r300->shader_constants[shader].user_count != i) {
         if (shader == PIPE_SHADER_FRAGMENT && r300->fs &&
@@ -168,6 +168,7 @@ static void
             r300_translate_vertex_shader(r300, r300->vs);
         }
     }
+#endif
 }
 
 /* Create a new depth, stencil, and alpha state based on the CSO dsa state.
@@ -315,7 +316,6 @@ static void r300_bind_fs_state(struct pipe_context* pipe, void* shader)
         r300_translate_fragment_shader(r300, fs);
     }
 
-    fs->translated = TRUE;
     r300->fs = fs;
 
     r300->dirty_state |= R300_NEW_FRAGMENT_SHADER;
diff --git a/src/gallium/drivers/r300/r300_vs.c b/src/gallium/drivers/r300/r300_vs.c
index a664a31..741a1b6 100644
--- a/src/gallium/drivers/r300/r300_vs.c
+++ b/src/gallium/drivers/r300/r300_vs.c
@@ -408,4 +408,7 @@ void r300_translate_vertex_shader(struct r300_context* r300,
 
     tgsi_parse_free(&parser);
     FREE(assembler);
+
+    /* And, finally... */
+    vs->translated = TRUE;
 }




More information about the mesa-commit mailing list