Mesa (master): mesa: Mark FBOs with compressed color attachments as FBO-incomplete.
Eric Anholt
anholt at kemper.freedesktop.org
Fri May 15 23:55:49 UTC 2009
Module: Mesa
Branch: master
Commit: 0307e609aa3e707eeb40051bd664d36f2340ba9b
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=0307e609aa3e707eeb40051bd664d36f2340ba9b
Author: Eric Anholt <eric at anholt.net>
Date: Fri May 15 16:24:59 2009 -0700
mesa: Mark FBOs with compressed color attachments as FBO-incomplete.
Both EXT_fbo and ARB_fbo agree on this. Fixes a segfault in the metaops
mipmap generation in Intel for SGIS_generate_mipmap of S3TC textures in
Regnum Online.
Bug #21654.
---
src/mesa/main/fbobject.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c
index 9c5a590..dbd4c58 100644
--- a/src/mesa/main/fbobject.c
+++ b/src/mesa/main/fbobject.c
@@ -368,6 +368,11 @@ test_attachment_completeness(const GLcontext *ctx, GLenum format,
att->Complete = GL_FALSE;
return;
}
+ if (texImage->TexFormat->TexelBytes == 0) {
+ att_incomplete("compressed internalformat");
+ att->Complete = GL_FALSE;
+ return;
+ }
}
else if (format == GL_DEPTH) {
if (texImage->TexFormat->BaseFormat == GL_DEPTH_COMPONENT) {
More information about the mesa-commit
mailing list