Mesa (master): r300-gallium: Die on bad texture formats.

Corbin Simpson csimpson at kemper.freedesktop.org
Sat May 16 18:24:04 UTC 2009


Module: Mesa
Branch: master
Commit: 08ec7e0d329a72433b427e8167b2c3442d1f53b4
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=08ec7e0d329a72433b427e8167b2c3442d1f53b4

Author: Corbin Simpson <MostAwesomeDude at gmail.com>
Date:   Sat May 16 11:17:05 2009 -0700

r300-gallium: Die on bad texture formats.

Odds are good that we'll die later anyway, so we might as well do it before
we start dancing on random memory.

---

 src/gallium/drivers/r300/r300_screen.c |   11 +++++++++--
 1 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/src/gallium/drivers/r300/r300_screen.c b/src/gallium/drivers/r300/r300_screen.c
index ab09502..6fe724c 100644
--- a/src/gallium/drivers/r300/r300_screen.c
+++ b/src/gallium/drivers/r300/r300_screen.c
@@ -232,9 +232,16 @@ static boolean r300_is_format_supported(struct pipe_screen* pscreen,
         case PIPE_TEXTURE_2D:
             return check_tex_2d_format(format,
                 r300_screen(pscreen)->caps->is_r500);
+        case PIPE_TEXTURE_1D:
+        case PIPE_TEXTURE_3D:
+        case PIPE_TEXTURE_CUBE:
+            debug_printf("r300: Implementation error: Unsupported format "
+                    "target: %d\n", target);
+            break;
         default:
-            debug_printf("r300: Warning: Got unknown format target: %d\n",
-                format);
+            debug_printf("r300: Fatal: This is not a format target: %d\n",
+                target);
+            assert(0);
             break;
     }
 




More information about the mesa-commit mailing list