Mesa (outputswritten64): i965: Kill DO_SETUP_BITS

Ian Romanick idr at kemper.freedesktop.org
Fri Nov 13 02:21:48 UTC 2009


Module: Mesa
Branch: outputswritten64
Commit: e32e9c725ef1daa68ba468707e83fa14f0b2016c
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=e32e9c725ef1daa68ba468707e83fa14f0b2016c

Author: Ian Romanick <ian.d.romanick at intel.com>
Date:   Thu Nov 12 18:20:33 2009 -0800

i965: Kill DO_SETUP_BITS

The DO_SETUP_BITS masking was completely bogus.  It used
FRAG_ATTRIB_MAX to operate on vertex shader outputs.  Eliminating it
makes vertex-to-fragment varyings work again.

---

 src/mesa/drivers/dri/i965/brw_context.h |    4 ----
 src/mesa/drivers/dri/i965/brw_sf.c      |    2 +-
 src/mesa/drivers/dri/i965/brw_wm.c      |    2 +-
 3 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/brw_context.h b/src/mesa/drivers/dri/i965/brw_context.h
index bc69c4b..f06b2b6 100644
--- a/src/mesa/drivers/dri/i965/brw_context.h
+++ b/src/mesa/drivers/dri/i965/brw_context.h
@@ -759,9 +759,5 @@ brw_fragment_program_const(const struct gl_fragment_program *p)
    return (const struct brw_fragment_program *) p;
 }
 
-
-
-#define DO_SETUP_BITS ((1<<(FRAG_ATTRIB_MAX)) - 1)
-
 #endif
 
diff --git a/src/mesa/drivers/dri/i965/brw_sf.c b/src/mesa/drivers/dri/i965/brw_sf.c
index 68df05a..e5b08e8 100644
--- a/src/mesa/drivers/dri/i965/brw_sf.c
+++ b/src/mesa/drivers/dri/i965/brw_sf.c
@@ -61,7 +61,7 @@ static void compile_sf_prog( struct brw_context *brw,
    c.key = *key;
    c.nr_attrs = brw_count_bits(c.key.attrs);
    c.nr_attr_regs = (c.nr_attrs+1)/2;
-   c.nr_setup_attrs = brw_count_bits(c.key.attrs & DO_SETUP_BITS);
+   c.nr_setup_attrs = brw_count_bits(c.key.attrs);
    c.nr_setup_regs = (c.nr_setup_attrs+1)/2;
 
    c.prog_data.urb_read_length = c.nr_attr_regs;
diff --git a/src/mesa/drivers/dri/i965/brw_wm.c b/src/mesa/drivers/dri/i965/brw_wm.c
index b6f3938..7baeea5 100644
--- a/src/mesa/drivers/dri/i965/brw_wm.c
+++ b/src/mesa/drivers/dri/i965/brw_wm.c
@@ -327,7 +327,7 @@ static void brw_wm_populate_key( struct brw_context *brw,
    }
 
    /* CACHE_NEW_VS_PROG */
-   key->vp_outputs_written = brw->vs.prog_data->outputs_written & DO_SETUP_BITS;
+   key->vp_outputs_written = brw->vs.prog_data->outputs_written;
 
    /* The unique fragment program ID */
    key->program_string_id = fp->id;




More information about the mesa-commit mailing list