Mesa (master): st/dri: no need to request fake front buffer, only handle it being returned
Ben Skeggs
darktama at kemper.freedesktop.org
Mon Oct 5 05:44:00 UTC 2009
Module: Mesa
Branch: master
Commit: 1336989ec60fff7bd590fefd28945a0e5dc536e3
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=1336989ec60fff7bd590fefd28945a0e5dc536e3
Author: Ben Skeggs <bskeggs at redhat.com>
Date: Mon Oct 5 15:32:55 2009 +1000
st/dri: no need to request fake front buffer, only handle it being returned
The previous behaviour was incorrect, and resulted in EXT_tfp being broken
for DDX drivers that implement the correct behaviour (intel/radeon/nouveau).
In the cases where a fake front buffer is required, the X server will
return one when requesting __DRI_BUFFER_FRONT_LEFT.
The Xorg state tracker (aka modesetting_drv) is likely broken now until
it's modified to match the other drivers.
Signed-off-by: Ben Skeggs <bskeggs at redhat.com>
---
src/gallium/state_trackers/dri/dri_drawable.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/src/gallium/state_trackers/dri/dri_drawable.c b/src/gallium/state_trackers/dri/dri_drawable.c
index 5cec9e3..6aafb38 100644
--- a/src/gallium/state_trackers/dri/dri_drawable.c
+++ b/src/gallium/state_trackers/dri/dri_drawable.c
@@ -179,7 +179,6 @@ dri_get_buffers(__DRIdrawablePrivate * dPriv)
switch (buffers[i].attachment) {
case __DRI_BUFFER_FRONT_LEFT:
- continue;
case __DRI_BUFFER_FAKE_FRONT_LEFT:
index = ST_SURFACE_FRONT_LEFT;
format = drawable->color_format;
@@ -360,8 +359,6 @@ dri_create_buffer(__DRIscreenPrivate * sPriv,
if (visual->doubleBufferMode)
drawable->attachments[i++] = __DRI_BUFFER_BACK_LEFT;
- else
- drawable->attachments[i++] = __DRI_BUFFER_FAKE_FRONT_LEFT;
if (visual->depthBits && visual->stencilBits)
drawable->attachments[i++] = __DRI_BUFFER_DEPTH_STENCIL;
else if (visual->depthBits)
More information about the mesa-commit
mailing list