Mesa (master): tgsi: add comment about potential code removal

Brian Paul brianp at kemper.freedesktop.org
Sun Apr 18 16:02:31 UTC 2010


Module: Mesa
Branch: master
Commit: 0490116f96e61c6d8d26c2383736990cceef799b
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=0490116f96e61c6d8d26c2383736990cceef799b

Author: Brian Paul <brianp at vmware.com>
Date:   Sun Apr 18 10:01:53 2010 -0600

tgsi: add comment about potential code removal

---

 src/gallium/auxiliary/tgsi/tgsi_exec.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/src/gallium/auxiliary/tgsi/tgsi_exec.c b/src/gallium/auxiliary/tgsi/tgsi_exec.c
index f853ea2..11045e4 100644
--- a/src/gallium/auxiliary/tgsi/tgsi_exec.c
+++ b/src/gallium/auxiliary/tgsi/tgsi_exec.c
@@ -1796,6 +1796,12 @@ exec_declaration(struct tgsi_exec_machine *mach,
          last = decl->Range.Last;
          mask = decl->Declaration.UsageMask;
 
+         /* XXX we could remove this special-case code since
+          * mach->InterpCoefs[first].a0 should already have the
+          * front/back-face value.  But we should first update the
+          * ureg code to emit the right UsageMask value (WRITEMASK_X).
+          * Then, we could remove the tgsi_exec_machine::Face field.
+          */
          if (decl->Semantic.Name == TGSI_SEMANTIC_FACE) {
             uint i;
 




More information about the mesa-commit mailing list