Mesa (master): glx: Fix use after free in drisw error path

Kristian Høgsberg krh at kemper.freedesktop.org
Wed Aug 4 12:58:46 UTC 2010


Module: Mesa
Branch: master
Commit: e3a0e468bc67e4169406bb4c96b5ab483dc48a28
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=e3a0e468bc67e4169406bb4c96b5ab483dc48a28

Author: Kristian Høgsberg <krh at bitplanet.net>
Date:   Wed Aug  4 08:57:02 2010 -0400

glx: Fix use after free in drisw error path

---

 src/glx/drisw_glx.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/src/glx/drisw_glx.c b/src/glx/drisw_glx.c
index 66a6043..c5b1791 100644
--- a/src/glx/drisw_glx.c
+++ b/src/glx/drisw_glx.c
@@ -502,10 +502,9 @@ driCreateScreen(int screen, struct glx_display *priv)
    return &psc->base;
 
  handle_error:
-   Xfree(psc);
-
    if (psc->driver)
       dlclose(psc->driver);
+   Xfree(psc);
 
    ErrorMessageF("reverting to indirect rendering\n");
 




More information about the mesa-commit mailing list