Mesa (master): glsl: Completely initialize value member in ir_constant constructor.

Vinson Lee vlee at kemper.freedesktop.org
Sun Aug 29 20:18:38 UTC 2010


Module: Mesa
Branch: master
Commit: 30a086552827b82738421ff2d562e3c8c1da2735
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=30a086552827b82738421ff2d562e3c8c1da2735

Author: Vinson Lee <vlee at vmware.com>
Date:   Sun Aug 29 13:15:56 2010 -0700

glsl: Completely initialize value member in ir_constant constructor.

The
ir_constant::ir_constant(const struct glsl_type *type, exec_list *value_list)
did not completely initialize the entire value member.

Fixes piglit glsl-fs-sampler-numbering-2 valgrind uninitialized value
error in softpipe and llvmpipe.

---

 src/glsl/ir.cpp |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/src/glsl/ir.cpp b/src/glsl/ir.cpp
index d56b603..992853c 100644
--- a/src/glsl/ir.cpp
+++ b/src/glsl/ir.cpp
@@ -409,6 +409,9 @@ ir_constant::ir_constant(const struct glsl_type *type, exec_list *value_list)
       return;
    }
 
+   for (unsigned i = 0; i < 16; i++) {
+      this->value.u[i] = 0;
+   }
 
    ir_constant *value = (ir_constant *) (value_list->head);
 




More information about the mesa-commit mailing list