Mesa (master): glsl: Initialize data in ast_function_expression::hir.

Vinson Lee vlee at kemper.freedesktop.org
Sun Aug 29 21:07:07 UTC 2010


Module: Mesa
Branch: master
Commit: 0c93e69b25559225d3124d5a0deaaeceabf8cb12
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=0c93e69b25559225d3124d5a0deaaeceabf8cb12

Author: Vinson Lee <vlee at vmware.com>
Date:   Sun Aug 29 14:05:07 2010 -0700

glsl: Initialize data in ast_function_expression::hir.

Completely initialize data that is passed to ir_constant constructor.

Fixes piglit glsl-orangebook-ch06-bump valgrind uninitialized variable
error on softpipe and llvmpipe.

---

 src/glsl/ast_function.cpp |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/glsl/ast_function.cpp b/src/glsl/ast_function.cpp
index 34b0f70..c2e526c 100644
--- a/src/glsl/ast_function.cpp
+++ b/src/glsl/ast_function.cpp
@@ -1193,7 +1193,7 @@ ast_function_expression::hir(exec_list *instructions,
 	  * causes the matrix to be filled with 0 and the diagonal to be
 	  * filled with the value.
 	  */
-	 ir_constant_data data;
+	 ir_constant_data data = { { 0 } };
 	 ir_constant *const initializer =
 	    (ir_constant *) actual_parameters.head;
 	 if (constructor_type->is_matrix())




More information about the mesa-commit mailing list