Mesa (master): i965: Set render_cache_read_write surface state bit on gen6 constant surfs.

Eric Anholt anholt at kemper.freedesktop.org
Thu Dec 9 19:24:35 UTC 2010


Module: Mesa
Branch: master
Commit: cfcc2ef587fad91ad1dff1abbd42886dbe9cc095
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=cfcc2ef587fad91ad1dff1abbd42886dbe9cc095

Author: Eric Anholt <eric at anholt.net>
Date:   Thu Dec  9 10:03:49 2010 -0800

i965: Set render_cache_read_write surface state bit on gen6 constant surfs.

This is said to be required in the spec, even when you aren't doing writes.

---

 src/mesa/drivers/dri/i965/brw_structs.h          |    5 +++++
 src/mesa/drivers/dri/i965/brw_wm_surface_state.c |    4 ++++
 2 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/brw_structs.h b/src/mesa/drivers/dri/i965/brw_structs.h
index 0e1f3c9..d341187 100644
--- a/src/mesa/drivers/dri/i965/brw_structs.h
+++ b/src/mesa/drivers/dri/i965/brw_structs.h
@@ -1179,6 +1179,11 @@ struct brw_surface_state
       GLuint cube_pos_x:1; 
       GLuint cube_neg_x:1; 
       GLuint pad:4;
+      /* Required on gen6 for surfaces accessed through render cache messages.
+       */
+      GLuint render_cache_read_write:1;
+      /* Ironlake and newer: instead of replicating one of the texels */
+      GLuint cube_corner_average:1;
       GLuint mipmap_layout_mode:1; 
       GLuint vert_line_stride_ofs:1; 
       GLuint vert_line_stride:1; 
diff --git a/src/mesa/drivers/dri/i965/brw_wm_surface_state.c b/src/mesa/drivers/dri/i965/brw_wm_surface_state.c
index 76fc94d..fb0e34e 100644
--- a/src/mesa/drivers/dri/i965/brw_wm_surface_state.c
+++ b/src/mesa/drivers/dri/i965/brw_wm_surface_state.c
@@ -274,6 +274,7 @@ brw_create_constant_surface(struct brw_context *brw,
 			    drm_intel_bo **out_bo,
 			    uint32_t *out_offset)
 {
+   struct intel_context *intel = &brw->intel;
    const GLint w = width - 1;
    struct brw_surface_state surf;
    void *map;
@@ -284,6 +285,9 @@ brw_create_constant_surface(struct brw_context *brw,
    surf.ss0.surface_type = BRW_SURFACE_BUFFER;
    surf.ss0.surface_format = BRW_SURFACEFORMAT_R32G32B32A32_FLOAT;
 
+   if (intel->gen >= 6)
+      surf.ss0.render_cache_read_write = 1;
+
    assert(bo);
    surf.ss1.base_addr = bo->offset; /* reloc */
 




More information about the mesa-commit mailing list