Mesa (master): mesa/swrast/st: add ARB_occlusion_query2 support.

Dave Airlie airlied at kemper.freedesktop.org
Sat Dec 18 07:39:20 UTC 2010


Module: Mesa
Branch: master
Commit: ff7aa554a11863de2c4c0b4b6d1ec7b07c819739
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=ff7aa554a11863de2c4c0b4b6d1ec7b07c819739

Author: Dave Airlie <airlied at redhat.com>
Date:   Sun Sep 12 06:31:30 2010 +1000

mesa/swrast/st: add ARB_occlusion_query2 support.

This gets my vote for most pointless extension of all time, I'm guessing
some driver could possibly optimise for this instead of counting it might
just get a true/false, but I'm not really sure.

need this to eventually advertise 3.3 despite its total uselessness.

Signed-off-by: Dave Airlie <airlied at redhat.com>

---

 docs/GL3.txt                           |    2 +-
 src/mesa/main/extensions.c             |    1 +
 src/mesa/main/queryobj.c               |   43 +++++++++++++++++++++++---------
 src/mesa/state_tracker/st_extensions.c |    1 +
 4 files changed, 34 insertions(+), 13 deletions(-)

diff --git a/docs/GL3.txt b/docs/GL3.txt
index fb22739..9106f43 100644
--- a/docs/GL3.txt
+++ b/docs/GL3.txt
@@ -71,7 +71,7 @@ GL 3.3:
 GLSL 3.30                                             not started
 GL_ARB_blend_func_extended                            not started
 GL_ARB_explicit_attrib_location                       DONE (swrast, i915, i965)
-GL_ARB_occlusion_query2                               not started
+GL_ARB_occlusion_query2                               DONE (swrast, gallium)
 GL_ARB_sampler_objects                                not started
 GL_ARB_texture_rgb10_a2ui                             not started
 GL_ARB_texture_swizzle                                DONE (same as EXT version)
diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c
index f3bf5cb..fd5b4e9 100644
--- a/src/mesa/main/extensions.c
+++ b/src/mesa/main/extensions.c
@@ -259,6 +259,7 @@ _mesa_enable_sw_extensions(struct gl_context *ctx)
    ctx->Extensions.ARB_multitexture = GL_TRUE;
 #if FEATURE_queryobj
    ctx->Extensions.ARB_occlusion_query = GL_TRUE;
+   ctx->Extensions.ARB_occlusion_query2 = GL_TRUE;
 #endif
    ctx->Extensions.ARB_point_sprite = GL_TRUE;
 #if FEATURE_ARB_shader_objects
diff --git a/src/mesa/main/queryobj.c b/src/mesa/main/queryobj.c
index 8874397..ca829b0 100644
--- a/src/mesa/main/queryobj.c
+++ b/src/mesa/main/queryobj.c
@@ -143,6 +143,11 @@ get_query_binding_point(struct gl_context *ctx, GLenum target)
          return &ctx->Query.CurrentOcclusionObject;
       else
          return NULL;
+   case GL_ANY_SAMPLES_PASSED:
+      if (ctx->Extensions.ARB_occlusion_query2)
+         return &ctx->Query.CurrentOcclusionObject;
+      else
+         return NULL;
    case GL_TIME_ELAPSED_EXT:
       if (ctx->Extensions.EXT_timer_query)
          return &ctx->Query.CurrentTimerObject;
@@ -378,12 +383,19 @@ _mesa_GetQueryObjectivARB(GLuint id, GLenum pname, GLint *params)
          if (!q->Ready)
             ctx->Driver.WaitQuery(ctx, q);
          /* if result is too large for returned type, clamp to max value */
-         if (q->Result > 0x7fffffff) {
-            *params = 0x7fffffff;
-         }
-         else {
-            *params = (GLint)q->Result;
-         }
+	 if (q->Target == GL_ANY_SAMPLES_PASSED) {
+	    if (q->Result)
+	       *params = GL_TRUE;
+	    else
+	       *params = GL_FALSE;
+	 } else {
+	    if (q->Result > 0x7fffffff) {
+	       *params = 0x7fffffff;
+	    }
+	    else {
+	       *params = (GLint)q->Result;
+	    }
+	 }
          break;
       case GL_QUERY_RESULT_AVAILABLE_ARB:
 	 if (!q->Ready)
@@ -418,12 +430,19 @@ _mesa_GetQueryObjectuivARB(GLuint id, GLenum pname, GLuint *params)
          if (!q->Ready)
             ctx->Driver.WaitQuery(ctx, q);
          /* if result is too large for returned type, clamp to max value */
-         if (q->Result > 0xffffffff) {
-            *params = 0xffffffff;
-         }
-         else {
-            *params = (GLuint)q->Result;
-         }
+	 if (q->Target == GL_ANY_SAMPLES_PASSED) {
+	    if (q->Result)
+	       *params = GL_TRUE;
+	    else
+	       *params = GL_FALSE;
+	 } else {
+	    if (q->Result > 0xffffffff) {
+	       *params = 0xffffffff;
+	    }
+	    else {
+	       *params = (GLuint)q->Result;
+	    }
+	 }
          break;
       case GL_QUERY_RESULT_AVAILABLE_ARB:
 	 if (!q->Ready)
diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c
index 51a45a7..62c9ce7 100644
--- a/src/mesa/state_tracker/st_extensions.c
+++ b/src/mesa/state_tracker/st_extensions.c
@@ -343,6 +343,7 @@ void st_init_extensions(struct st_context *st)
 
    if (screen->get_param(screen, PIPE_CAP_OCCLUSION_QUERY)) {
       ctx->Extensions.ARB_occlusion_query = GL_TRUE;
+      ctx->Extensions.ARB_occlusion_query2 = GL_TRUE;
    }
    if (screen->get_param(screen, PIPE_CAP_TIMER_QUERY)) {
      ctx->Extensions.EXT_timer_query = GL_TRUE;




More information about the mesa-commit mailing list