Mesa (master): r300g: disable the MIP filter for NPOT textures
Corbin Simpson
csimpson at kemper.freedesktop.org
Sun Jan 17 09:14:57 UTC 2010
Module: Mesa
Branch: master
Commit: 21f3bbf1495ce44ecde4f353fed9f85e6e0fdd2d
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=21f3bbf1495ce44ecde4f353fed9f85e6e0fdd2d
Author: Marek Olšák <maraeo at gmail.com>
Date: Sat Jan 16 00:48:53 2010 +0100
r300g: disable the MIP filter for NPOT textures
Safety first.
---
src/gallium/drivers/r300/r300_emit.c | 18 ++++++++++++------
1 files changed, 12 insertions(+), 6 deletions(-)
diff --git a/src/gallium/drivers/r300/r300_emit.c b/src/gallium/drivers/r300/r300_emit.c
index 9f93327..11bd334 100644
--- a/src/gallium/drivers/r300/r300_emit.c
+++ b/src/gallium/drivers/r300/r300_emit.c
@@ -705,12 +705,18 @@ void r300_emit_texture(struct r300_context* r300,
filter0 |= R300_TX_WRAP_T(R300_TX_CLAMP_TO_EDGE);
}
- /* determine min/max levels */
- /* the MAX_MIP level is the largest (finest) one */
- max_level = MIN2(sampler->max_lod, tex->tex.last_level);
- min_level = MIN2(sampler->min_lod, max_level);
- format0 |= R300_TX_NUM_LEVELS(max_level);
- filter0 |= R300_TX_MAX_MIP_LEVEL(min_level);
+ if (tex->is_npot) {
+ /* NPOT textures don't support mip filter, unfortunately.
+ * This prevents incorrect rendering. */
+ filter0 &= ~R300_TX_MIN_FILTER_MIP_MASK;
+ } else {
+ /* determine min/max levels */
+ /* the MAX_MIP level is the largest (finest) one */
+ max_level = MIN2(sampler->max_lod, tex->tex.last_level);
+ min_level = MIN2(sampler->min_lod, max_level);
+ format0 |= R300_TX_NUM_LEVELS(max_level);
+ filter0 |= R300_TX_MAX_MIP_LEVEL(min_level);
+ }
BEGIN_CS(16);
OUT_CS_REG(R300_TX_FILTER0_0 + (offset * 4), filter0 |
More information about the mesa-commit
mailing list