Mesa (glsl2): ast: Initialize location data in constructor of all ast_node objects.

Carl Worth cworth at kemper.freedesktop.org
Fri Jul 30 22:03:56 UTC 2010


Module: Mesa
Branch: glsl2
Commit: ec9675ec533cc0c0c7b1c738280e9b9adf2591fb
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=ec9675ec533cc0c0c7b1c738280e9b9adf2591fb

Author: Carl Worth <cworth at cworth.org>
Date:   Thu Jul 29 16:39:36 2010 -0700

ast: Initialize location data in constructor of all ast_node objects.

This prevents using uninitialized data in _msea_glsl_error in some
cases, (including at least 6 piglit tests). Thanks to valgrind for
pointing out the problem!

---

 src/glsl/glsl_parser_extras.cpp |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/src/glsl/glsl_parser_extras.cpp b/src/glsl/glsl_parser_extras.cpp
index 20a5021..15fa61d 100644
--- a/src/glsl/glsl_parser_extras.cpp
+++ b/src/glsl/glsl_parser_extras.cpp
@@ -280,7 +280,9 @@ ast_node::print(void) const
 
 ast_node::ast_node(void)
 {
-   /* empty */
+   this->location.source = 0;
+   this->location.line = 0;
+   this->location.column = 0;
 }
 
 




More information about the mesa-commit mailing list