Mesa (master): gallivm: alloca() was called too often for temporary arrays

Brian Paul brianp at kemper.freedesktop.org
Fri Nov 5 14:52:19 UTC 2010


Module: Mesa
Branch: master
Commit: e8d6b2793ff3907d3646eeaceaa00e2a04728e67
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=e8d6b2793ff3907d3646eeaceaa00e2a04728e67

Author: Brian Paul <brianp at vmware.com>
Date:   Fri Nov  5 08:49:53 2010 -0600

gallivm: alloca() was called too often for temporary arrays

Need to increment the array index to point to the last value.
Before, we were calling lp_build_array_alloca() over and over for
no reason.

---

 src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c b/src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c
index a74cefd..897b09f 100644
--- a/src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c
+++ b/src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c
@@ -1189,10 +1189,12 @@ emit_declaration(
       case TGSI_FILE_TEMPORARY:
          assert(idx < LP_MAX_TGSI_TEMPS);
          if (bld->indirect_files & (1 << TGSI_FILE_TEMPORARY)) {
+            /* ignore 'first' - we want to index into a 0-based array */
             LLVMValueRef array_size = LLVMConstInt(LLVMInt32Type(),
                                                    last*4 + 4, 0);
             bld->temps_array = lp_build_array_alloca(bld->base.builder,
                                                      vec_type, array_size, "temparray");
+            idx = last;
          } else {
             for (i = 0; i < NUM_CHANNELS; i++)
                bld->temps[idx][i] = lp_build_alloca(bld->base.builder,




More information about the mesa-commit mailing list