Mesa (master): glsl: Fix ast-to-hir for ARB_fragment_coord_conventions

Ian Romanick idr at kemper.freedesktop.org
Mon Oct 25 17:12:50 UTC 2010


Module: Mesa
Branch: master
Commit: 6e006273840282e06a08655553821ef8176b2d9c
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=6e006273840282e06a08655553821ef8176b2d9c

Author: Chad Versace <chad.versace at intel.com>
Date:   Sat Oct 23 10:40:40 2010 -0700

glsl: Fix ast-to-hir for ARB_fragment_coord_conventions

Function ast_declarator_list::hir(), when processing keywords added by
extension ARB_fragment_coord_conventions, made the mistake of checking only if
the extension was __supported by the driver__. The correct behavior is to check
if the extensi0n is __enabled in the parse state__.

NOTE: this is a candidate for the 7.9 branch.

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

---

 src/glsl/ast_to_hir.cpp |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp
index 15e1afc..4540e98 100644
--- a/src/glsl/ast_to_hir.cpp
+++ b/src/glsl/ast_to_hir.cpp
@@ -2210,7 +2210,7 @@ ast_declarator_list::hir(exec_list *instructions,
 	    earlier->type = var->type;
 	    delete var;
 	    var = NULL;
-	 } else if (state->extensions->ARB_fragment_coord_conventions
+	 } else if (state->ARB_fragment_coord_conventions_enable
 		    && strcmp(var->name, "gl_FragCoord") == 0
 		    && earlier->type == var->type
 		    && earlier->mode == var->mode) {




More information about the mesa-commit mailing list