Mesa (master): glsl: Change from has_builtin_signature to has_user_signature.

Kenneth Graunke kwg at kemper.freedesktop.org
Thu Sep 16 10:11:17 UTC 2010


Module: Mesa
Branch: master
Commit: 81f03393982c29f8f4165b5629c8e8fb708b97a3
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=81f03393982c29f8f4165b5629c8e8fb708b97a3

Author: Kenneth Graunke <kenneth at whitecape.org>
Date:   Thu Sep 16 02:52:25 2010 -0700

glsl: Change from has_builtin_signature to has_user_signature.

The print visitor needs this, and the only existing user can work with
has_user_signature just as well.

---

 src/glsl/ast_to_hir.cpp |    2 +-
 src/glsl/ir.cpp         |    4 ++--
 src/glsl/ir.h           |    4 ++--
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp
index 31bb40d..9638544 100644
--- a/src/glsl/ast_to_hir.cpp
+++ b/src/glsl/ast_to_hir.cpp
@@ -2285,7 +2285,7 @@ ast_function::hir(exec_list *instructions,
     * that the previously seen signature does not have an associated definition.
     */
    f = state->symbols->get_function(name);
-   if (f != NULL && (state->es_shader || !f->has_builtin_signature())) {
+   if (f != NULL && (state->es_shader || f->has_user_signature())) {
       sig = f->exact_matching_signature(&hir_parameters);
       if (sig != NULL) {
 	 const char *badvar = sig->qualifiers_match(&hir_parameters);
diff --git a/src/glsl/ir.cpp b/src/glsl/ir.cpp
index 86dc490..7cc55d4 100644
--- a/src/glsl/ir.cpp
+++ b/src/glsl/ir.cpp
@@ -1137,11 +1137,11 @@ ir_function::ir_function(const char *name)
 
 
 bool
-ir_function::has_builtin_signature()
+ir_function::has_user_signature()
 {
    foreach_list(n, &this->signatures) {
       ir_function_signature *const sig = (ir_function_signature *) n;
-      if (sig->is_builtin)
+      if (!sig->is_builtin)
 	 return true;
    }
    return false;
diff --git a/src/glsl/ir.h b/src/glsl/ir.h
index 70c6faa..b3b15bb 100644
--- a/src/glsl/ir.h
+++ b/src/glsl/ir.h
@@ -410,8 +410,8 @@ public:
     */
    const char *name;
 
-   /** Whether or not this function has a signature that is a built-in. */
-   bool has_builtin_signature();
+   /** Whether or not this function has a signature that isn't a built-in. */
+   bool has_user_signature();
 
    /**
     * List of ir_function_signature for each overloaded function with this name.




More information about the mesa-commit mailing list